Paths

Table of Contentst

Differential D11583

[web] update `WorkerCryptoStore` to handle session version
ClosedPublic
Actions

Authored by kamil on Mon, Apr 8, 6:47 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Apr 22, 1:46 AM

	Unknown Object (File)
	Wed, Apr 17, 8:39 AM

	Unknown Object (File)
	Tue, Apr 16, 10:42 AM

	Unknown Object (File)
	Tue, Apr 16, 7:25 AM

	Unknown Object (File)
	Mon, Apr 15, 8:48 PM

	Unknown Object (File)
	Sun, Apr 14, 11:13 AM

	Unknown Object (File)
	Sun, Apr 14, 9:33 AM

	Unknown Object (File)
	Sat, Apr 13, 11:03 AM

View All 12 Files

Subscribers

Details

Reviewers

bartek
marcin
tomek

Commits

rCOMMcab25122c49c: [web] update `WorkerCryptoStore` to handle session version

Summary

Updates in-memory CryptoStore to work with session versions.

Depends on D11582

Test Plan

Tested in TBD

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Mon, Apr 8, 6:47 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptMon, Apr 8, 6:47 AM

Harbormaster failed remote builds in B28055: Diff 38905!Mon, Apr 8, 7:24 AM

kamil added a child revision: D11586: [web] update session creation code to handle versioning.Mon, Apr 8, 7:25 AM

rebase

Harbormaster completed remote builds in B28085: Diff 38935.Tue, Apr 9, 5:13 AM

kamil published this revision for review.Tue, Apr 9, 6:01 AM

kamil added inline comments.

web/shared-worker/worker/worker-crypto.js
439 ↗	(On Diff #38905)	updated in D11586
467 ↗	(On Diff #38905)	updated in D11586

marcin accepted this revision.Wed, Apr 10, 6:31 AM

This revision is now accepted and ready to land.Wed, Apr 10, 6:31 AM

Closed by commit rCOMMcab25122c49c: [web] update `WorkerCryptoStore` to handle session version (authored by kamil). · Explain WhyThu, Apr 11, 4:47 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMcab25122c49c: [web] update `WorkerCryptoStore` to handle session version.

ashoat added inline comments.Fri, Apr 12, 6:36 AM

web/shared-worker/worker/worker-crypto.js
63	Sorry for adding this comment late, but this could be made read-only

kamil added inline comments.Mon, Apr 22, 3:51 AM

web/shared-worker/worker/worker-crypto.js
63	If I recall correctly this was by design, so we can modify one session in in-memory `cryptoStore` (see line 74) without updating the entire object. If you still think it's better to make this read-only and update rest of the code I can put up a diff

ashoat added inline comments.Mon, Apr 22, 5:02 AM

web/shared-worker/worker/worker-crypto.js
63	Thanks for explaining! Looks like it's been thought through, so it's fine to leave as-is

Revision Contents
Changeset List

Path

Size

web/

shared-worker/

worker/

worker-crypto.js

46 lines

Diff 39043

web/shared-worker/worker/worker-crypto.js

Loading...