Page MenuHomePhabricator

[web] update `WorkerCryptoStore` to handle session version
ClosedPublic

Authored by kamil on Apr 8 2024, 6:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 24, 12:47 PM
Unknown Object (File)
Sun, Nov 24, 10:43 AM
Unknown Object (File)
Sun, Nov 24, 8:58 AM
Unknown Object (File)
Sun, Nov 3, 8:12 AM
Unknown Object (File)
Oct 12 2024, 10:59 PM
Unknown Object (File)
Oct 12 2024, 10:59 PM
Unknown Object (File)
Oct 12 2024, 10:59 PM
Unknown Object (File)
Oct 12 2024, 10:58 PM
Subscribers

Details

Summary

Updates in-memory CryptoStore to work with session versions.

Depends on D11582

Test Plan

Tested in TBD

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Apr 9 2024, 6:01 AM
kamil added inline comments.
web/shared-worker/worker/worker-crypto.js
439 ↗(On Diff #38905)

updated in D11586

467 ↗(On Diff #38905)

updated in D11586

This revision is now accepted and ready to land.Apr 10 2024, 6:31 AM
web/shared-worker/worker/worker-crypto.js
63

Sorry for adding this comment late, but this could be made read-only

web/shared-worker/worker/worker-crypto.js
63

If I recall correctly this was by design, so we can modify one session in in-memory cryptoStore (see line 74) without updating the entire object.

If you still think it's better to make this read-only and update rest of the code I can put up a diff

web/shared-worker/worker/worker-crypto.js
63

Thanks for explaining! Looks like it's been thought through, so it's fine to leave as-is