Page MenuHomePhabricator
Differential D11627

Rename addSyncedMetadata and removeSyncedMetadata action types to set and clear
ClosedPublic
Actions

Authored by will on Apr 10 2024, 11:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 22, 1:15 PM
Unknown Object (File)
Mon, Apr 21, 6:08 AM
Unknown Object (File)
Mon, Apr 21, 3:23 AM
Unknown Object (File)
Sun, Apr 20, 10:05 PM
Unknown Object (File)
Sun, Apr 20, 7:06 AM
Unknown Object (File)
Wed, Apr 9, 12:34 AM
Unknown Object (File)
Tue, Apr 8, 8:56 PM
Unknown Object (File)
Tue, Apr 8, 8:25 PM
View All 68 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
ginsu
Commits
rCOMM340733ee63e9: Rename addSyncedMetadata and removeSyncedMetadata action types to set and clear
Summary

Thought this naming convention was cleaner. Matching the naming convention of operations on our other metadata data type.

Depends on D11626

Test Plan

flow check

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
actions/
9 lines
reducers/
8 lines
types/
12 lines
4 lines

Diff 39169

View Options

lib/actions/synced-metadata-actions.js

// @flow // @flow
const addSyncedMetadataEntryActionType = 'ADD_SYNCED_METADATA_ENTRY'; const setSyncedMetadataEntryActionType = 'SET_SYNCED_METADATA_ENTRY';
const removeSyncedMetadataEntryActionType = 'REMOVE_SYNCED_METADATA_ENTRY'; const clearSyncedMetadataEntryActionType = 'CLEAR_SYNCED_METADATA_ENTRY';
export { export { setSyncedMetadataEntryActionType, clearSyncedMetadataEntryActionType };
addSyncedMetadataEntryActionType,
removeSyncedMetadataEntryActionType,
};
View Options

lib/reducers/synced-metadata-reducer.js

// @flow // @flow
import { setClientDBStoreActionType } from '../actions/client-db-store-actions.js'; import { setClientDBStoreActionType } from '../actions/client-db-store-actions.js';
import { import {
addSyncedMetadataEntryActionType, setSyncedMetadataEntryActionType,
removeSyncedMetadataEntryActionType, clearSyncedMetadataEntryActionType,
} from '../actions/synced-metadata-actions.js'; } from '../actions/synced-metadata-actions.js';
import { import {
syncedMetadataStoreOpsHandlers, syncedMetadataStoreOpsHandlers,
type SyncedMetadataStoreOperation, type SyncedMetadataStoreOperation,
type ReplaceSyncedMetadataEntryOperation, type ReplaceSyncedMetadataEntryOperation,
type RemoveSyncedMetadataOperation, type RemoveSyncedMetadataOperation,
} from '../ops/synced-metadata-store-ops.js'; } from '../ops/synced-metadata-store-ops.js';
import type { BaseAction } from '../types/redux-types.js'; import type { BaseAction } from '../types/redux-types.js';
import type { SyncedMetadataStore } from '../types/synced-metadata-types.js'; import type { SyncedMetadataStore } from '../types/synced-metadata-types.js';
const { processStoreOperations: processStoreOps } = const { processStoreOperations: processStoreOps } =
syncedMetadataStoreOpsHandlers; syncedMetadataStoreOpsHandlers;
function reduceSyncedMetadataStore( function reduceSyncedMetadataStore(
state: SyncedMetadataStore, state: SyncedMetadataStore,
action: BaseAction, action: BaseAction,
): { ): {
+syncedMetadataStore: SyncedMetadataStore, +syncedMetadataStore: SyncedMetadataStore,
+syncedMetadataStoreOperations: $ReadOnlyArray<SyncedMetadataStoreOperation>, +syncedMetadataStoreOperations: $ReadOnlyArray<SyncedMetadataStoreOperation>,
} { } {
if (action.type === addSyncedMetadataEntryActionType) { if (action.type === setSyncedMetadataEntryActionType) {
const replaceOperation: ReplaceSyncedMetadataEntryOperation = { const replaceOperation: ReplaceSyncedMetadataEntryOperation = {
type: 'replace_synced_metadata_entry', type: 'replace_synced_metadata_entry',
payload: action.payload, payload: action.payload,
}; };
return { return {
syncedMetadataStore: processStoreOps(state, [replaceOperation]), syncedMetadataStore: processStoreOps(state, [replaceOperation]),
syncedMetadataStoreOperations: [replaceOperation], syncedMetadataStoreOperations: [replaceOperation],
}; };
} else if (action.type === removeSyncedMetadataEntryActionType) { } else if (action.type === clearSyncedMetadataEntryActionType) {
const removeOperation: RemoveSyncedMetadataOperation = { const removeOperation: RemoveSyncedMetadataOperation = {
type: 'remove_synced_metadata', type: 'remove_synced_metadata',
payload: { payload: {
names: [action.payload.name], names: [action.payload.name],
}, },
}; };
return { return {
Show All 31 Lines
View Options

lib/types/redux-types.js

Show First 20 Lines • Show All 109 Lines • ▼ Show 20 Linesimport type {
StateSyncFullActionPayload, StateSyncFullActionPayload,
StateSyncIncrementalActionPayload, StateSyncIncrementalActionPayload,
SetActiveSessionRecoveryPayload, SetActiveSessionRecoveryPayload,
} from './socket-types.js'; } from './socket-types.js';
import { type ClientStore } from './store-ops-types.js'; import { type ClientStore } from './store-ops-types.js';
import type { SubscriptionUpdateResult } from './subscription-types.js'; import type { SubscriptionUpdateResult } from './subscription-types.js';
import type { import type {
SyncedMetadataStore, SyncedMetadataStore,
AddSyncedMetadataEntryPayload, SetSyncedMetadataEntryPayload,
RemoveSyncedMetadataEntryPayload, ClearSyncedMetadataEntryPayload,
} from './synced-metadata-types.js'; } from './synced-metadata-types.js';
import type { GlobalThemeInfo } from './theme-types.js'; import type { GlobalThemeInfo } from './theme-types.js';
import type { ThreadActivityStore } from './thread-activity-types.js'; import type { ThreadActivityStore } from './thread-activity-types.js';
import type { import type {
ThreadStore, ThreadStore,
ChangeThreadSettingsPayload, ChangeThreadSettingsPayload,
LeaveThreadPayload, LeaveThreadPayload,
NewThreadResult, NewThreadResult,
▲ Show 20 Lines • Show All 1,240 Lines • ▼ Show 20 Lines | {
+type: 'SET_CONNECTION_ISSUE', +type: 'SET_CONNECTION_ISSUE',
+payload: { +connectionIssue: ?ConnectionIssue, +keyserverID: string }, +payload: { +connectionIssue: ?ConnectionIssue, +keyserverID: string },
} }
| { | {
+type: 'ADD_COMMUNITY', +type: 'ADD_COMMUNITY',
+payload: AddCommunityPayload, +payload: AddCommunityPayload,
} }
| { | {
+type: 'ADD_SYNCED_METADATA_ENTRY', +type: 'SET_SYNCED_METADATA_ENTRY',
+payload: AddSyncedMetadataEntryPayload, +payload: SetSyncedMetadataEntryPayload,
} }
| { | {
+type: 'REMOVE_SYNCED_METADATA_ENTRY', +type: 'CLEAR_SYNCED_METADATA_ENTRY',
+payload: RemoveSyncedMetadataEntryPayload, +payload: ClearSyncedMetadataEntryPayload,
} }
| { | {
+type: 'SET_ACTIVE_SESSION_RECOVERY', +type: 'SET_ACTIVE_SESSION_RECOVERY',
+payload: SetActiveSessionRecoveryPayload, +payload: SetActiveSessionRecoveryPayload,
} }
| { | {
+type: 'SET_FARCASTER_FRIENDS_FID', +type: 'SET_FARCASTER_FRIENDS_FID',
+payload: SetFarcasterFriendsFIDPayload, +payload: SetFarcasterFriendsFIDPayload,
Show All 27 Lines
View Options

lib/types/synced-metadata-types.js

// @flow // @flow
export type SyncedMetadata = { +[name: string]: string }; export type SyncedMetadata = { +[name: string]: string };
export type SyncedMetadataStore = { export type SyncedMetadataStore = {
+syncedMetadata: SyncedMetadata, +syncedMetadata: SyncedMetadata,
}; };
export type AddSyncedMetadataEntryPayload = { export type SetSyncedMetadataEntryPayload = {
+name: string, +name: string,
+data: string, +data: string,
}; };
export type RemoveSyncedMetadataEntryPayload = { export type ClearSyncedMetadataEntryPayload = {
+name: string, +name: string,
}; };