Page MenuHomePhabricator
Differential D11683

[native] implement UI for selecting a farcaster channel
ClosedPublic
Actions

Authored by ginsu on Wed, Apr 17, 11:14 PM.
Tags
None
Referenced Files
F1776955: D11683.diff
Thu, May 16, 9:50 PM
Unknown Object (File)
Thu, May 2, 6:00 PM
Unknown Object (File)
Thu, May 2, 1:08 AM
Unknown Object (File)
Wed, May 1, 7:24 PM
Unknown Object (File)
Sat, Apr 27, 4:03 AM
Unknown Object (File)
Sat, Apr 27, 3:20 AM
Unknown Object (File)
Fri, Apr 26, 3:33 PM
Unknown Object (File)
Fri, Apr 26, 12:58 PM
View All 16 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
ashoat
Commits
rCOMM560e48ea3541: Revert "[web][native][keyserver] Flip the switch to enable `specialRole` field"
rCOMM780b38b899e3: [native] implement UI for selecting a farcaster channel
Summary

This diff introduces the action sheet "dropdown component" for selecting a farcaster channel that the user follows and wants to tag to their Comm community.

Please note that the UI for this screen is still a WIP and subsequent diffs will introduce the rest of the elements needed on this screen (ie the submit button)

Linear task: https://linear.app/comm/issue/ENG-7546/introduce-a-farcaster-dropdown-component + https://linear.app/comm/issue/ENG-7545/fetch-all-the-farcaster-channels-the-community-creatoradmin-is-active

Depends on D11682

Test Plan

Please see the demo video below

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Wed, Apr 17, 11:14 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptWed, Apr 17, 11:14 PM
ginsu edited the summary of this revision. (Show Details)Wed, Apr 17, 11:23 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu added a parent revision: D11682: [native] introduce screen options to tag farcaster channel stack navigator.
ginsu attached a referenced file: F1567095: Screen Recording 2024-04-18 at 2.11.45 AM.mov. (Show Details)
ginsu added a reviewer: ashoat.

Making @ashoat a blocking reviewer since this diff introduces copy changes

native/community-settings/tag-farcaster-channel/tag-farcaster-channel.react.js
108

This copy needs to be reviewed

115–116

This copy needs to be reviewed

Harbormaster completed remote builds in B28283: Diff 39207.Wed, Apr 17, 11:31 PM
ginsu requested review of this revision.Wed, Apr 17, 11:31 PM
ginsu added inline comments.Thu, Apr 18, 11:27 AM
native/community-settings/tag-farcaster-channel/tag-farcaster-channel.react.js
108

"channels" should probably be "channel"

ashoat resigned from this revision.Thu, Apr 18, 11:56 AM

Thanks for adding me!

native/community-settings/tag-farcaster-channel/tag-farcaster-channel.react.js
108

+1, let's use "channel"

115–116

Hmm, how about this:

Tag a Farcaster channel so followers can find your Comm community!

Still going back-and-forth on whether the exclamation mark is too excited. Open to alternative suggestions

ginsu added inline comments.Thu, Apr 18, 12:03 PM
native/community-settings/tag-farcaster-channel/tag-farcaster-channel.react.js
115–116

Still going back-and-forth on whether the exclamation mark is too excited.

I think the exclamation mark is a bit much imo.

115–116

would love one of the reviewers to also give some input on this too

atul accepted this revision.Fri, Apr 19, 2:01 PM
atul added inline comments.
native/community-settings/tag-farcaster-channel/tag-farcaster-channel.react.js
115–116

Personally prefer including the exclamation mark

146–170

Are the modal* colors the right ones to use for this screen?

This revision is now accepted and ready to land.Fri, Apr 19, 2:01 PM
ginsu added inline comments.Mon, Apr 22, 10:46 AM
native/community-settings/tag-farcaster-channel/tag-farcaster-channel.react.js
146–170

Thanks for this shout, I confused myself earlier with the naming, but yes we should use panel here over modal

ginsu updated this revision to Diff 39347.EditedMon, Apr 22, 11:03 AM

address comments (also confirmed that changing from to panel color family from modal color family caused no regressions with the UI:

Screenshot 2024-04-22 at 1.58.30 PM.png (1×1 px, 701 KB)

ginsu attached a referenced file: F1632875: Screenshot 2024-04-22 at 1.58.30 PM.png. (Show Details)Mon, Apr 22, 11:06 AM
This revision was landed with ongoing or failed builds.Mon, Apr 22, 11:07 AM
Closed by commit rCOMM780b38b899e3: [native] implement UI for selecting a farcaster channel (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM780b38b899e3: [native] implement UI for selecting a farcaster channel.
Harbormaster completed remote builds in B28358: Diff 39347.Mon, Apr 22, 11:20 AM
atul added a commit: rCOMM560e48ea3541: Revert "[web][native][keyserver] Flip the switch to enable `specialRole` field".Mon, Apr 22, 12:26 PM

Revision Contents
Changeset List

PathSize
native/
community-settings/
tag-farcaster-channel/
152 lines

Diff 39207

View Options

native/community-settings/tag-farcaster-channel/tag-farcaster-channel.react.js

Loading...