[native] implement UI for selecting a farcaster channel
ClosedPublic
Actions

Authored by ginsu on Apr 17 2024, 11:14 PM.

Details

Reviewers

atul
inka
ashoat

Commits

rCOMM560e48ea3541: Revert "[web][native][keyserver] Flip the switch to enable `specialRole` field"
rCOMM780b38b899e3: [native] implement UI for selecting a farcaster channel

Summary

This diff introduces the action sheet "dropdown component" for selecting a farcaster channel that the user follows and wants to tag to their Comm community.

Please note that the UI for this screen is still a WIP and subsequent diffs will introduce the rest of the elements needed on this screen (ie the submit button)

Linear task: https://linear.app/comm/issue/ENG-7546/introduce-a-farcaster-dropdown-component + https://linear.app/comm/issue/ENG-7545/fetch-all-the-farcaster-channels-the-community-creatoradmin-is-active

Depends on D11682

Test Plan

Please see the demo video below

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Apr 17 2024, 11:14 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptApr 17 2024, 11:14 PM

Making @ashoat a blocking reviewer since this diff introduces copy changes

native/community-settings/tag-farcaster-channel/tag-farcaster-channel.react.js
108 ↗	(On Diff #39207)	This copy needs to be reviewed
115–116 ↗	(On Diff #39207)	This copy needs to be reviewed

Harbormaster completed remote builds in B28283: Diff 39207.Apr 17 2024, 11:31 PM

ginsu requested review of this revision.Apr 17 2024, 11:31 PM

ginsu added inline comments.Apr 18 2024, 11:27 AM

native/community-settings/tag-farcaster-channel/tag-farcaster-channel.react.js
108 ↗	(On Diff #39207)	"channels" should probably be "channel"

Thanks for adding me!

native/community-settings/tag-farcaster-channel/tag-farcaster-channel.react.js
108 ↗	(On Diff #39207)	+1, let's use "channel"
115–116 ↗	(On Diff #39207)	Hmm, how about this: Tag a Farcaster channel so followers can find your Comm community! Still going back-and-forth on whether the exclamation mark is too excited. Open to alternative suggestions

ginsu added inline comments.Apr 18 2024, 12:03 PM

native/community-settings/tag-farcaster-channel/tag-farcaster-channel.react.js
115–116 ↗	(On Diff #39207)	Still going back-and-forth on whether the exclamation mark is too excited. I think the exclamation mark is a bit much imo.
115–116 ↗	(On Diff #39207)	would love one of the reviewers to also give some input on this too

atul accepted this revision.Apr 19 2024, 2:01 PM

atul added inline comments.

native/community-settings/tag-farcaster-channel/tag-farcaster-channel.react.js
115–116 ↗	(On Diff #39207)	Personally prefer including the exclamation mark
146–170 ↗	(On Diff #39207)	Are the `modal*` colors the right ones to use for this screen?