Page MenuHomePhabricator

[identity] Refactor device list types
ClosedPublic

Authored by bartek on May 6 2024, 3:13 AM.
Tags
None
Referenced Files
F3295666: D11898.diff
Sat, Nov 16, 10:36 PM
Unknown Object (File)
Sun, Nov 10, 11:41 AM
Unknown Object (File)
Sat, Nov 9, 7:01 PM
Unknown Object (File)
Sat, Nov 9, 12:14 AM
Unknown Object (File)
Fri, Nov 8, 7:17 PM
Unknown Object (File)
Fri, Nov 8, 7:17 PM
Unknown Object (File)
Oct 12 2024, 4:31 AM
Unknown Object (File)
Oct 11 2024, 1:44 AM
Subscribers

Details

Summary

Did some refactoring to make it clear what some structs are designed to be. Previous structure was designed to have Identity sign device lists as well, but we finally opted out of it (only primary device signs them).

Short summary:

  • UpdateDeviceListRequest is a request coming from primary device calling update RPCs
  • SignedDeviceList is a JSON payload, Whitepaper 6.2.3
  • RawDeviceList is a helper struct for inner stringified JSON (see whitepaper)
  • DeviceListUpdate is actual payload containing device list data to be processed in DDB transaction (some more details in the next diff)

Depends on D11897

Test Plan

Unit and integration tests. Device list logic works as before.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.May 6 2024, 3:33 AM
kamil added inline comments.
services/identity/src/device_list.rs
441 ↗(On Diff #39833)

can we make the name less generic?

This revision is now accepted and ready to land.May 6 2024, 4:35 AM
This revision was automatically updated to reflect the committed changes.