Page MenuHomePhabricator
Differential D11944

[lib][keyserver] Move thread and siwe validators to lib
ClosedPublic
Actions

Authored by inka on May 8 2024, 7:16 AM.
Tags
None
Referenced Files
F3306829: D11944.diff
Mon, Nov 18, 10:46 PM
Unknown Object (File)
Mon, Nov 11, 8:35 PM
Unknown Object (File)
Mon, Nov 11, 8:06 PM
Unknown Object (File)
Mon, Nov 11, 6:17 PM
Unknown Object (File)
Mon, Nov 11, 9:35 AM
Unknown Object (File)
Sat, Oct 26, 11:51 AM
Unknown Object (File)
Oct 10 2024, 11:21 PM
Unknown Object (File)
Oct 10 2024, 11:21 PM
View All 51 Files
Subscribers
ashoat

Details

Reviewers
kamil
tomek
bartek
Commits
rCOMMe7c6948e69de: [lib][keyserver] Move thread and siwe validators to lib
Summary

issue: ENG-7818
Move output validators to lib

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Branch
inka/userStore
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.May 8 2024, 7:16 AM
Herald added a subscriber: ashoat. · View Herald TranscriptMay 8 2024, 7:16 AM
inka added a parent revision: D11943: [lib][keyserver] Move report and search validators to lib.May 8 2024, 7:16 AM
inka added a child revision: D11945: [lib][keyserver] Move user and version validators to lib.May 8 2024, 7:33 AM
Harbormaster completed remote builds in B28763: Diff 39933.May 8 2024, 7:33 AM
inka requested review of this revision.May 8 2024, 7:33 AM
tomek accepted this revision.May 8 2024, 10:04 AM

Wondering if there's a pattern in choosing which validators were moved together in a diff.

This revision is now accepted and ready to land.May 8 2024, 10:04 AM
bartek accepted this revision.May 9 2024, 12:11 AM
inka added a comment.May 9 2024, 2:36 AM
In D11944#341688, @tomek wrote:

Wondering if there's a pattern in choosing which validators were moved together in a diff.

Up to two files, paired by what was next to each other in the endpoints.js file 😄
My thinking was that it doesn't really matter what is paired with what in this kind of a diff, so I just did it top to bottom

Closed by commit rCOMMe7c6948e69de: [lib][keyserver] Move thread and siwe validators to lib (authored by inka). · Explain WhyMay 9 2024, 2:54 AM
This revision was automatically updated to reflect the committed changes.
inka added a commit: rCOMMe7c6948e69de: [lib][keyserver] Move thread and siwe validators to lib.

Revision Contents
Changeset List

PathSize
keyserver/
src/
24 lines
responders/
8 lines
5 lines
68 lines
lib/
types/
validators/
9 lines
84 lines

Diff 39933

View Options

keyserver/src/endpoints.js

Loading...
View Options

keyserver/src/responders/responder-validators.test.js

Loading...
View Options

keyserver/src/responders/siwe-nonce-responders.js

Loading...
View Options

keyserver/src/responders/thread-responders.js

Loading...
View Options

lib/types/validators/siwe-nonce-validators.js

Loading...
View Options

lib/types/validators/thread-validators.js

Loading...