Page MenuHomePhabricator
Differential D12000

[native/web] make `findUserIdentities` RPC available to native and web
ClosedPublic
Actions

Authored by will on May 10 2024, 9:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 12, 10:30 PM
Unknown Object (File)
Sun, Mar 9, 8:45 AM
Unknown Object (File)
Sun, Mar 2, 6:16 PM
Unknown Object (File)
Fri, Feb 28, 12:33 PM
Unknown Object (File)
Thu, Feb 27, 2:03 PM
Unknown Object (File)
Thu, Feb 27, 2:01 PM
Unknown Object (File)
Sun, Feb 23, 12:04 AM
Unknown Object (File)
Thu, Feb 20, 11:10 AM
View All Files
Subscribers
ashoat
inka
tomek

Details

Reviewers
bartek
kamil
Commits
rCOMMfb67cd1ec8a1: [native/web] make `findUserIdentities` RPC available to native and web
Summary

Implements FindUserIdentities RPC for web and native

Depends on D11999

Test Plan

On both web/native successfully called the FindUserIdentities rpc on

  1. ethereum user
  2. username user
  3. user with farcaster id
  4. non-existent user (resulting in no entry in the identities result)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will created this revision.May 10 2024, 9:51 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 10 2024, 9:51 PM
will updated this revision to Diff 40093.May 10 2024, 9:59 PM

remove Object from ethereum identity validator

Harbormaster completed remote builds in B28851: Diff 40092.May 10 2024, 10:07 PM
Harbormaster completed remote builds in B28852: Diff 40093.May 10 2024, 10:15 PM
will requested review of this revision.May 10 2024, 10:15 PM
ashoat added inline comments.May 12 2024, 7:02 PM
lib/types/identity-service-types.js
244 ↗(On Diff #40093)

We generally type farcasterID instead of farcasterId. Is there a way to do that here?

will added a child revision: D12011: [lib] dispatch actions and populate aux user store with fids.May 12 2024, 8:10 PM
bartek mentioned this in D11998: [native] implement 'FindUserIdentities' RPC in `native_rust_library`.May 13 2024, 12:12 AM
bartek added inline comments.May 13 2024, 12:16 AM
lib/types/identity-service-types.js
244 ↗(On Diff #40093)

On native there is, added a comment: https://phab.comm.dev/D11998#inline-71174

But for web, we need to do a manual rename in the forEach() call in L633

bartek added a subscriber: inka.May 13 2024, 6:47 AM
will planned changes to this revision.May 13 2024, 3:44 PM

Planning changes to address Ashoat's comment on changing farcasterId to farcasterID

will updated this revision to Diff 40200.May 14 2024, 11:22 PM

use farcasterID instead of farcasterID on native/web

Harbormaster completed remote builds in B28926: Diff 40200.May 14 2024, 11:39 PM
kamil resigned from this revision.May 14 2024, 11:53 PM

Looks good but I wasn't reviewing previous diffs in the stack so letting @bartek do the final approval on whether type definitions and API usage are correct

bartek accepted this revision.May 15 2024, 12:24 AM

Looks good now

This revision is now accepted and ready to land.May 15 2024, 12:24 AM
will updated this revision to Diff 40256.May 15 2024, 12:16 PM

rebase before landing

will updated this revision to Diff 40257.May 15 2024, 12:18 PM

rebase

Harbormaster failed remote builds in B28961: Diff 40257!May 15 2024, 12:31 PM
Harbormaster completed remote builds in B28960: Diff 40256.
will updated this revision to Diff 40265.May 15 2024, 7:34 PM

rebase

Harbormaster failed remote builds in B28968: Diff 40265!May 15 2024, 7:46 PM
will updated this revision to Diff 40267.May 15 2024, 8:01 PM

rebase

Harbormaster completed remote builds in B28970: Diff 40267.May 15 2024, 8:17 PM
Closed by commit rCOMMfb67cd1ec8a1: [native/web] make `findUserIdentities` RPC available to native and web (authored by will). · Explain WhyMay 15 2024, 8:30 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMMfb67cd1ec8a1: [native/web] make `findUserIdentities` RPC available to native and web.

Revision Contents
Changeset List

Diff 40256

View Options

lib/types/identity-service-types.js

// @flow // @flow
import { import {
setDeviceTokenActionTypes, setDeviceTokenActionTypes,
type SetDeviceTokenStartedPayload, type SetDeviceTokenStartedPayload,
} from '../actions/device-actions.js'; } from '../actions/device-actions.js';
import { setTBDeviceTokenActionTypes } from '../actions/tunnelbroker-actions.js'; import {
invalidateTunnelbrokerDeviceToken,
setTBDeviceTokenActionTypes,
} from '../actions/tunnelbroker-actions.js';
import type { BaseAction } from '../types/redux-types.js'; import type { BaseAction } from '../types/redux-types.js';
import type { TunnelbrokerDeviceToken } from '../types/tunnelbroker-device-token-types.js'; import type { TunnelbrokerDeviceToken } from '../types/tunnelbroker-device-token-types.js';
function reduceTunnelbrokerDeviceToken( function reduceTunnelbrokerDeviceToken(
state: TunnelbrokerDeviceToken, state: TunnelbrokerDeviceToken,
action: BaseAction, action: BaseAction,
): TunnelbrokerDeviceToken { ): TunnelbrokerDeviceToken {
if (action.type === setDeviceTokenActionTypes.started) { if (action.type === setDeviceTokenActionTypes.started) {
const payload: SetDeviceTokenStartedPayload = action.payload; const payload: SetDeviceTokenStartedPayload = action.payload;
if (payload.type === 'nothing_to_set') { if (payload.type === 'nothing_to_set') {
return state; return state;
} }
if (payload.type === 'clear_device_token') { if (payload.type === 'clear_device_token') {
return { ...state, localToken: null }; return { ...state, localToken: null };
} }
return { ...state, localToken: payload.deviceToken }; return { ...state, localToken: payload.deviceToken };
} else if (action.type === setTBDeviceTokenActionTypes.success) { } else if (action.type === setTBDeviceTokenActionTypes.success) {
const { deviceToken } = action.payload; const { deviceToken } = action.payload;
return { ...state, tunnelbrokerToken: deviceToken }; return { ...state, tunnelbrokerToken: deviceToken };
} else if (action.type === invalidateTunnelbrokerDeviceToken) {
const { deviceToken } = action.payload;
if (state.localToken !== deviceToken) {
return state;
}
return {
...state,
localToken: null,
tunnelbrokerToken: null,
};
} }
return state; return state;
} }
export default reduceTunnelbrokerDeviceToken; export default reduceTunnelbrokerDeviceToken;
View Options

native/identity-service/identity-service-context-provider.react.js

// @flow // @flow
import { import {
setDeviceTokenActionTypes, setDeviceTokenActionTypes,
type SetDeviceTokenStartedPayload, type SetDeviceTokenStartedPayload,
} from '../actions/device-actions.js'; } from '../actions/device-actions.js';
import { setTBDeviceTokenActionTypes } from '../actions/tunnelbroker-actions.js'; import {
invalidateTunnelbrokerDeviceToken,
setTBDeviceTokenActionTypes,
} from '../actions/tunnelbroker-actions.js';
import type { BaseAction } from '../types/redux-types.js'; import type { BaseAction } from '../types/redux-types.js';
import type { TunnelbrokerDeviceToken } from '../types/tunnelbroker-device-token-types.js'; import type { TunnelbrokerDeviceToken } from '../types/tunnelbroker-device-token-types.js';
function reduceTunnelbrokerDeviceToken( function reduceTunnelbrokerDeviceToken(
state: TunnelbrokerDeviceToken, state: TunnelbrokerDeviceToken,
action: BaseAction, action: BaseAction,
): TunnelbrokerDeviceToken { ): TunnelbrokerDeviceToken {
if (action.type === setDeviceTokenActionTypes.started) { if (action.type === setDeviceTokenActionTypes.started) {
const payload: SetDeviceTokenStartedPayload = action.payload; const payload: SetDeviceTokenStartedPayload = action.payload;
if (payload.type === 'nothing_to_set') { if (payload.type === 'nothing_to_set') {
return state; return state;
} }
if (payload.type === 'clear_device_token') { if (payload.type === 'clear_device_token') {
return { ...state, localToken: null }; return { ...state, localToken: null };
} }
return { ...state, localToken: payload.deviceToken }; return { ...state, localToken: payload.deviceToken };
} else if (action.type === setTBDeviceTokenActionTypes.success) { } else if (action.type === setTBDeviceTokenActionTypes.success) {
const { deviceToken } = action.payload; const { deviceToken } = action.payload;
return { ...state, tunnelbrokerToken: deviceToken }; return { ...state, tunnelbrokerToken: deviceToken };
} else if (action.type === invalidateTunnelbrokerDeviceToken) {
const { deviceToken } = action.payload;
if (state.localToken !== deviceToken) {
return state;
}
return {
...state,
localToken: null,
tunnelbrokerToken: null,
};
} }
return state; return state;
} }
export default reduceTunnelbrokerDeviceToken; export default reduceTunnelbrokerDeviceToken;
View Options

web/grpc/identity-service-client-wrapper.js

// @flow // @flow
import { import {
setDeviceTokenActionTypes, setDeviceTokenActionTypes,
type SetDeviceTokenStartedPayload, type SetDeviceTokenStartedPayload,
} from '../actions/device-actions.js'; } from '../actions/device-actions.js';
import { setTBDeviceTokenActionTypes } from '../actions/tunnelbroker-actions.js'; import {
invalidateTunnelbrokerDeviceToken,
setTBDeviceTokenActionTypes,
} from '../actions/tunnelbroker-actions.js';
import type { BaseAction } from '../types/redux-types.js'; import type { BaseAction } from '../types/redux-types.js';
import type { TunnelbrokerDeviceToken } from '../types/tunnelbroker-device-token-types.js'; import type { TunnelbrokerDeviceToken } from '../types/tunnelbroker-device-token-types.js';
function reduceTunnelbrokerDeviceToken( function reduceTunnelbrokerDeviceToken(
state: TunnelbrokerDeviceToken, state: TunnelbrokerDeviceToken,
action: BaseAction, action: BaseAction,
): TunnelbrokerDeviceToken { ): TunnelbrokerDeviceToken {
if (action.type === setDeviceTokenActionTypes.started) { if (action.type === setDeviceTokenActionTypes.started) {
const payload: SetDeviceTokenStartedPayload = action.payload; const payload: SetDeviceTokenStartedPayload = action.payload;
if (payload.type === 'nothing_to_set') { if (payload.type === 'nothing_to_set') {
return state; return state;
} }
if (payload.type === 'clear_device_token') { if (payload.type === 'clear_device_token') {
return { ...state, localToken: null }; return { ...state, localToken: null };
} }
return { ...state, localToken: payload.deviceToken }; return { ...state, localToken: payload.deviceToken };
} else if (action.type === setTBDeviceTokenActionTypes.success) { } else if (action.type === setTBDeviceTokenActionTypes.success) {
const { deviceToken } = action.payload; const { deviceToken } = action.payload;
return { ...state, tunnelbrokerToken: deviceToken }; return { ...state, tunnelbrokerToken: deviceToken };
} else if (action.type === invalidateTunnelbrokerDeviceToken) {
const { deviceToken } = action.payload;
if (state.localToken !== deviceToken) {
return state;
}
return {
...state,
localToken: null,
tunnelbrokerToken: null,
};
} }
return state; return state;
} }
export default reduceTunnelbrokerDeviceToken; export default reduceTunnelbrokerDeviceToken;
View Options

web/grpc/identity-service-context-provider.react.js

// @flow // @flow
import { import {
setDeviceTokenActionTypes, setDeviceTokenActionTypes,
type SetDeviceTokenStartedPayload, type SetDeviceTokenStartedPayload,
} from '../actions/device-actions.js'; } from '../actions/device-actions.js';
import { setTBDeviceTokenActionTypes } from '../actions/tunnelbroker-actions.js'; import {
invalidateTunnelbrokerDeviceToken,
setTBDeviceTokenActionTypes,
} from '../actions/tunnelbroker-actions.js';
import type { BaseAction } from '../types/redux-types.js'; import type { BaseAction } from '../types/redux-types.js';
import type { TunnelbrokerDeviceToken } from '../types/tunnelbroker-device-token-types.js'; import type { TunnelbrokerDeviceToken } from '../types/tunnelbroker-device-token-types.js';
function reduceTunnelbrokerDeviceToken( function reduceTunnelbrokerDeviceToken(
state: TunnelbrokerDeviceToken, state: TunnelbrokerDeviceToken,
action: BaseAction, action: BaseAction,
): TunnelbrokerDeviceToken { ): TunnelbrokerDeviceToken {
if (action.type === setDeviceTokenActionTypes.started) { if (action.type === setDeviceTokenActionTypes.started) {
const payload: SetDeviceTokenStartedPayload = action.payload; const payload: SetDeviceTokenStartedPayload = action.payload;
if (payload.type === 'nothing_to_set') { if (payload.type === 'nothing_to_set') {
return state; return state;
} }
if (payload.type === 'clear_device_token') { if (payload.type === 'clear_device_token') {
return { ...state, localToken: null }; return { ...state, localToken: null };
} }
return { ...state, localToken: payload.deviceToken }; return { ...state, localToken: payload.deviceToken };
} else if (action.type === setTBDeviceTokenActionTypes.success) { } else if (action.type === setTBDeviceTokenActionTypes.success) {
const { deviceToken } = action.payload; const { deviceToken } = action.payload;
return { ...state, tunnelbrokerToken: deviceToken }; return { ...state, tunnelbrokerToken: deviceToken };
} else if (action.type === invalidateTunnelbrokerDeviceToken) {
const { deviceToken } = action.payload;
if (state.localToken !== deviceToken) {
return state;
}
return {
...state,
localToken: null,
tunnelbrokerToken: null,
};
} }
return state; return state;
} }
export default reduceTunnelbrokerDeviceToken; export default reduceTunnelbrokerDeviceToken;