Differential D12018

undefined
ClosedPublic
Actions

Authored by ashoat on May 13 2024, 12:59 PM.

Details

Reviewers

inka

Commits

rCOMM8387fe36a5ea: [native] Make it possible for coolOrNerdMode/keyserverURL to be set to…

Summary

This makes the following diff a little bit easier, and is otherwise not a significant change.

These two lines in the following diff are the reason that this diff is necessary.

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.May 13 2024, 12:59 PM

Herald added a subscriber: tomek. · View Herald TranscriptMay 13 2024, 12:59 PM

ashoat added a child revision: D12019: [native] Refocus ConnectEthereum if registration fails due to expired nonce.May 13 2024, 1:00 PM

Harbormaster completed remote builds in B28874: Diff 40133.May 13 2024, 1:15 PM

ashoat requested review of this revision.May 13 2024, 1:15 PM

ashoat edited the summary of this revision. (Show Details)May 13 2024, 2:15 PM

ashoat added inline comments.

native/account/registration/username-selection.react.js
76–81 ↗	(On Diff #40133)	I guess this would probably look cleaner in ternary syntax

inka accepted this revision.May 14 2024, 5:57 AM

This revision is now accepted and ready to land.May 14 2024, 5:57 AM

Closed by commit rCOMM8387fe36a5ea: [native] Make it possible for coolOrNerdMode/keyserverURL to be set to… (authored by ashoat). · Explain WhyMay 14 2024, 7:05 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM8387fe36a5ea: [native] Make it possible for coolOrNerdMode/keyserverURL to be set to….

Revision Contents
Changeset List

Path

Size

native/

account/

registration/

avatar-selection.react.js

4 lines

connect-ethereum.react.js

4 lines

password-selection.react.js

4 lines

registration-terms.react.js

4 lines

registration-types.js

4 lines

siwe-backup-message-creation.react.js

4 lines

username-selection.react.js

16 lines

Diff 40160

View Options

native/account/registration/avatar-selection.react.js

View Options

native/account/registration/connect-ethereum.react.js

View Options

native/account/registration/password-selection.react.js

View Options

native/account/registration/registration-terms.react.js

View Options

native/account/registration/registration-types.js

View Options

native/account/registration/siwe-backup-message-creation.react.js

View Options

native/account/registration/username-selection.react.js

[native] Make it possible for coolOrNerdMode/keyserverURL to be set to null/undefinedClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 40160

native/account/registration/avatar-selection.react.js

native/account/registration/connect-ethereum.react.js

native/account/registration/password-selection.react.js

native/account/registration/registration-terms.react.js

native/account/registration/registration-types.js

native/account/registration/siwe-backup-message-creation.react.js

native/account/registration/username-selection.react.js

[native] Make it possible for coolOrNerdMode/keyserverURL to be set to null/undefined
ClosedPublic
Actions

Revision Contents
Changeset List