Introduced cargo workspace for services, shared and rust-node-addon.
Some context in this comment.
I put inline comments to explain it better.
This is the first and most important diff in the stack.
Details
Details
- Reviewers
varun - Commits
- rCOMM2c0a48ffe7a8: Introduce Cargo workspace and update Dockerfiles
- Locally: cargo commands inside packages work as before
- When ran in repo root, e.g. cargo check runs wor the whole workspace
- Docker build times and image sizes are comparable to non-workspace setup
- Pre-commit hooks for Rust still work as before
- CI: All Docker images are built successfully, including Keyserver
- CI: All non-Docker jobs (e.g. Android, iOS) compile Rust successfully
- Ran Services with Commtest locally
- Commtest on CI runs - it requires all services' docker images + its own Docker
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| keyserver/Dockerfile | ||
|---|---|---|
| 145–147 ↗ | (On Diff #40514) | For keyserver, we don't copy any of services into Docker image, so cargo build would fail with Couldn't find 'services/*/Cargo.toml' - no such file or directory. |
| services/backup/Dockerfile | ||
| 7 ↗ | (On Diff #40514) | Directory structure inside Docker image must follow structure from repo. Otherwise Cargo won't be able to find correct paths |
| 19 ↗ | (On Diff #40514) | Similarly to keyserver scenario, this sed removes rust-node-addon from workspace members because it's not copied into Docker image and Cargo would be unable to find it. It should work without the others now (they're now excluded), I'll check it and apply this change in the next revision |
| services/commtest/src/identity/mod.rs | ||
| 2 ↗ | (On Diff #40514) | When I included CommTest into workspace, it downloaded a littne newer version of ed25519_dalek which replaced SignerMut with Signer |
| services/identity/Dockerfile | ||
| 14–23 ↗ | (On Diff #40514) | This was to cache dependencies when only modifying sources. But from my experience, it wasn't saving much time. |