Paths

Table of Contentst

Differential D12178

[rust] Fix Clippy warnings about DateTime
ClosedPublic
Actions

Authored by bartek on Wed, May 22, 5:55 AM.

Details

Reviewers

varun

Commits

rCOMM4d5d38fa8f1b: [rust] Fix Clippy warnings about DateTime

Summary

Received a warn that the chrono::NaiveDateTime::from_timestamp is deprecated. Replaced this with recommended method which also simplified our code

Depends on D12176

Test Plan

cargo check
CI - there are some unit and integration tests that rely on timestamps

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Wed, May 22, 5:55 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptWed, May 22, 5:55 AM

bartek added a child revision: D12179: [rust] Fix Clippy warnings.Wed, May 22, 5:58 AM

Harbormaster failed remote builds in B29164: Diff 40535!Wed, May 22, 6:00 AM

bartek edited the summary of this revision. (Show Details)Wed, May 22, 7:10 AM

bartek added a parent revision: D12176: [blob] Fix Clippy warnings in Blob service.

Rebase

Harbormaster completed remote builds in B29173: Diff 40544.Wed, May 22, 7:42 AM

bartek published this revision for review.Wed, May 22, 7:44 AM

varun accepted this revision.Wed, May 22, 7:46 AM

This revision is now accepted and ready to land.Wed, May 22, 7:46 AM

Closed by commit rCOMM4d5d38fa8f1b: [rust] Fix Clippy warnings about DateTime (authored by bartek). · Explain WhyTue, May 28, 8:12 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM4d5d38fa8f1b: [rust] Fix Clippy warnings about DateTime.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

ddb_utils.rs

13 lines

device_list.rs

22 lines

grpc_services/

authenticated.rs

5 lines

shared/

comm-lib/

src/

auth/

service.rs

5 lines

database.rs

16 lines

Diff 40726

View Options

services/identity/src/ddb_utils.rs

View Options

services/identity/src/device_list.rs

View Options

services/identity/src/grpc_services/authenticated.rs

View Options

shared/comm-lib/src/auth/service.rs

View Options

shared/comm-lib/src/database.rs

[rust] Fix Clippy warnings about DateTimeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 40726

services/identity/src/ddb_utils.rs

services/identity/src/device_list.rs

services/identity/src/grpc_services/authenticated.rs

shared/comm-lib/src/auth/service.rs

shared/comm-lib/src/database.rs

[rust] Fix Clippy warnings about DateTime
ClosedPublic
Actions

Revision Contents
Changeset List