Inherit crate dependencies from workspace root
ClosedPublic
Actions

Authored by bartek on May 22 2024, 5:34 AM.

Details

Reviewers

varun

Commits

rCOMM95d8724f9dd2: Inherit crate dependencies from workspace root

Summary

Used a tool named cargo-autoinherit.
It automatically finds dependencies that have common version number across all workspace and hoists them to root Cargo.toml

Depends on D12171

Test Plan

cargo check --workspace
CI
Lockfile hasn't been changed - package versions are still the same

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.May 22 2024, 5:34 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 22 2024, 5:34 AM

bartek added a child revision: D12173: [backup] Remove unnecessary aws_types dependency.May 22 2024, 5:35 AM

Harbormaster failed remote builds in B29158: Diff 40529!May 22 2024, 5:37 AM

Rebase

Harbormaster failed remote builds in B29166: Diff 40537!May 22 2024, 7:04 AM

Rebase on fix

Harbormaster completed remote builds in B29167: Diff 40538.May 22 2024, 7:22 AM

bartek published this revision for review.May 22 2024, 7:32 AM

bartek edited the test plan for this revision. (Show Details)

should we create backlog tasks for the crates that aren't being inherited from the workspace root? in particular, it would be great to get all our crates on the same version of tonic

This revision is now accepted and ready to land.May 24 2024, 10:16 AM

In D12172#347646, @varun wrote:

should we create backlog tasks for the crates that aren't being inherited from the workspace root? in particular, it would be great to get all our crates on the same version of tonic

I've already created ENG-8176.

Closed by commit rCOMM95d8724f9dd2: Inherit crate dependencies from workspace root (authored by bartek). · Explain WhyMay 28 2024, 8:12 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM95d8724f9dd2: Inherit crate dependencies from workspace root.