Page MenuHomePhabricator

Inherit crate dependencies from workspace root
ClosedPublic

Authored by bartek on Wed, May 22, 5:34 AM.
Tags
None
Referenced Files
F2014804: D12172.id40537.diff
Fri, Jun 14, 3:08 PM
Unknown Object (File)
Thu, Jun 13, 9:22 PM
Unknown Object (File)
Thu, Jun 13, 10:51 AM
Unknown Object (File)
Tue, Jun 11, 2:59 AM
Unknown Object (File)
Mon, Jun 10, 8:17 PM
Unknown Object (File)
Sun, Jun 9, 1:40 PM
Unknown Object (File)
Sun, Jun 9, 12:40 PM
Unknown Object (File)
Sun, Jun 9, 11:14 AM
Subscribers

Details

Summary

Used a tool named cargo-autoinherit.
It automatically finds dependencies that have common version number across all workspace and hoists them to root Cargo.toml

Depends on D12171

Test Plan
  • cargo check --workspace
  • CI
  • Lockfile hasn't been changed - package versions are still the same

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.Wed, May 22, 7:32 AM
bartek edited the test plan for this revision. (Show Details)

should we create backlog tasks for the crates that aren't being inherited from the workspace root? in particular, it would be great to get all our crates on the same version of tonic

This revision is now accepted and ready to land.Fri, May 24, 10:16 AM

should we create backlog tasks for the crates that aren't being inherited from the workspace root? in particular, it would be great to get all our crates on the same version of tonic

I've already created ENG-8176.