[lib] Add `MemberInfoSansPermissions` support to `threadOtherMembers`
ClosedPublic
Actions

Authored by atul on Jun 5 2024, 2:42 PM.

Details

Reviewers

ashoat
ginsu
tomek

Commits

rCOMMb6356f154af9: [lib] Add `MemberInfoSansPermissions` support to `threadOtherMembers`

Summary

This resolves a flow issue when RawThreadInfo.members are of type MemberInfoSansPermissions.

Depends on D12315

Test Plan

NA, flow issue later in stack is resolved.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Jun 5 2024, 2:42 PM

atul published this revision for review.Jun 5 2024, 2:50 PM

Harbormaster completed remote builds in B29462: Diff 40997.Jun 5 2024, 2:59 PM

ginsu accepted this revision.Jun 5 2024, 3:17 PM

This revision is now accepted and ready to land.Jun 5 2024, 3:17 PM

land

This revision was landed with ongoing or failed builds.Jun 18 2024, 12:46 PM

Closed by commit rCOMMb6356f154af9: [lib] Add `MemberInfoSansPermissions` support to `threadOtherMembers` (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMb6356f154af9: [lib] Add `MemberInfoSansPermissions` support to `threadOtherMembers`.

Harbormaster completed remote builds in B29758: Diff 41465.Jun 18 2024, 1:01 PM

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

7 lines

Diff 41466

View Options

lib/shared/thread-utils.js

	#pragma once			#pragma once

	#include <string>			#include <string>
	#include <vector>			#include <vector>

	namespace comm {			namespace comm {
	class BackupOperationsExecutor {			class BackupOperationsExecutor {
	public:			public:
	static void createMainCompaction(std::string backupID, size_t futureID);			static void createMainCompaction(std::string backupID, size_t futureID);
	static void restoreFromMainCompaction(			static void restoreFromMainCompaction(
	std::string mainCompactionPath,			std::string mainCompactionPath,
	std::string mainCompactionEncryptionKey,			std::string mainCompactionEncryptionKey,
	size_t futureID);			size_t futureID);
	static void restoreFromBackupLog(const std::vector<std::uint8_t> &backupLog);			static void restoreFromBackupLog(
				const std::vector<std::uint8_t> &backupLog,
				size_t futureID);
	};			};
	} // namespace comm			} // namespace comm

[lib] Add `MemberInfoSansPermissions` support to `threadOtherMembers`ClosedPublicActions