[lib] Pull `baseThreadIsWithBlockedUserOnly` out of `baseThreadIsWithBlockedUserOnly[WithoutAdminRoleCheck]`
ClosedPublic
Actions

Authored by atul on Jun 3 2024, 2:10 PM.

Details

Reviewers

ashoat
ginsu
tomek
varun

Commits

rCOMM48530a39381e: [lib] Pull `baseThreadIsWithBlockedUserOnly` out of…

Summary

Pull common logic out of the two functions to reduce duplication and make things more readable.

Depends on D12294

Test Plan

flow + close reading, should be super simple refactor.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Jun 3 2024, 2:10 PM

atul published this revision for review.Jun 3 2024, 2:10 PM

Harbormaster completed remote builds in B29403: Diff 40904.Jun 3 2024, 2:27 PM

atul added a child revision: D12296: [lib] Rename `MemberInfo` to `MemberInfoWithPermissions`.Jun 3 2024, 2:41 PM

tomek accepted this revision.Jun 4 2024, 2:40 AM

This revision is now accepted and ready to land.Jun 4 2024, 2:40 AM

ashoat accepted this revision.Jun 4 2024, 11:42 AM

ashoat mentioned this in D12289: [lib] Introduce `threadIsWithBlockedUserOnlyWithoutAdminRoleCheck`.

land

This revision was landed with ongoing or failed builds.Jun 17 2024, 2:15 PM

Closed by commit rCOMM48530a39381e: [lib] Pull `baseThreadIsWithBlockedUserOnly` out of… (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM48530a39381e: [lib] Pull `baseThreadIsWithBlockedUserOnly` out of….

Harbormaster completed remote builds in B29726: Diff 41418.Jun 17 2024, 2:31 PM

Revision Contents
Changeset List

Path

Size

lib/

shared/

thread-utils.js

55 lines

Diff 41419

View Options

lib/shared/thread-utils.js

[lib] Pull `baseThreadIsWithBlockedUserOnly` out of `baseThreadIsWithBlockedUserOnly[WithoutAdminRoleCheck]`ClosedPublicActions