Page MenuHomePhabricator
Differential D12295

[lib] Pull `baseThreadIsWithBlockedUserOnly` out of `baseThreadIsWithBlockedUserOnly[WithoutAdminRoleCheck]`
ClosedPublic
Actions

Authored by atul on Jun 3 2024, 2:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 16, 5:06 PM
Unknown Object (File)
Wed, Apr 16, 9:43 AM
Unknown Object (File)
Wed, Apr 16, 4:08 AM
Unknown Object (File)
Tue, Apr 15, 7:46 PM
Unknown Object (File)
Tue, Apr 15, 12:39 PM
Unknown Object (File)
Tue, Apr 15, 10:14 AM
Unknown Object (File)
Tue, Apr 8, 6:17 PM
Unknown Object (File)
Sun, Mar 30, 11:49 AM
View All 83 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
varun
Commits
rCOMM48530a39381e: [lib] Pull `baseThreadIsWithBlockedUserOnly` out of…
Summary

Pull common logic out of the two functions to reduce duplication and make things more readable.

Depends on D12294

Test Plan

flow + close reading, should be super simple refactor.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
shared/
55 lines

Diff 41419

View Options

lib/shared/thread-utils.js

Show First 20 Lines • Show All 217 Lines • ▼ Show 20 Lines return createPromiseAsJSIValue(
jsiStringToRustString(accessToken, innerRt), jsiStringToRustString(accessToken, innerRt),
currentID); currentID);
} catch (const std::exception &e) { } catch (const std::exception &e) {
error = e.what(); error = e.what();
}; };
}); });
} }
jsi::Value CommRustModule::getOutboundKeysForUserDevice( jsi::Value CommRustModule::getOutboundKeysForUser(
jsi::Runtime &rt, jsi::Runtime &rt,
jsi::String authUserID, jsi::String authUserID,
jsi::String authDeviceID, jsi::String authDeviceID,
jsi::String authAccessToken, jsi::String authAccessToken,
jsi::String userID, jsi::String userID) {
jsi::String deviceID) {
return createPromiseAsJSIValue( return createPromiseAsJSIValue(
rt, [&, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) { rt, [&, this](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
std::string error; std::string error;
try { try {
auto currentID = RustPromiseManager::instance.addPromise( auto currentID = RustPromiseManager::instance.addPromise(
promise, this->jsInvoker_, innerRt); promise, this->jsInvoker_, innerRt);
identityGetOutboundKeysForUserDevice( identityGetOutboundKeysForUser(
jsiStringToRustString(authUserID, innerRt), jsiStringToRustString(authUserID, innerRt),
jsiStringToRustString(authDeviceID, innerRt), jsiStringToRustString(authDeviceID, innerRt),
jsiStringToRustString(authAccessToken, innerRt), jsiStringToRustString(authAccessToken, innerRt),
jsiStringToRustString(userID, innerRt), jsiStringToRustString(userID, innerRt),
jsiStringToRustString(deviceID, innerRt),
currentID); currentID);
} catch (const std::exception &e) { } catch (const std::exception &e) {
error = e.what(); error = e.what();
}; };
}); });
} }
jsi::Value CommRustModule::versionSupported(jsi::Runtime &rt) { jsi::Value CommRustModule::versionSupported(jsi::Runtime &rt) {
Show All 14 Lines