Page MenuHomePhabricator

[lib] Rename `MemberInfo` to `MemberInfoWithPermissions`
ClosedPublic

Authored by atul on Jun 3 2024, 2:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 6:35 AM
Unknown Object (File)
Wed, Nov 20, 10:07 PM
Unknown Object (File)
Sat, Nov 16, 1:08 AM
Unknown Object (File)
Sun, Nov 10, 11:38 PM
Unknown Object (File)
Sun, Nov 10, 10:55 PM
Unknown Object (File)
Sun, Nov 10, 10:14 PM
Unknown Object (File)
Sun, Nov 10, 9:22 PM
Unknown Object (File)
Sun, Nov 10, 3:05 PM
Subscribers
None

Details

Summary

This is to make room for MemberInfoWithoutPermissions or MemberInfoSansPermissions, etc.

We're going to need both in different places in the codebase. Specifically we'll definitely need MemberInfoWithPermissions when constructing RawThreadInfos for old clients, etc.

The goal at the end of the stack is for the client to only deal with MemberInfoSansPermissions.

Will try to make the changes as minimal as possible...


Depends on D12295

Test Plan

flow/NA just a simple rename

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

include validator rename

atul published this revision for review.Jun 3 2024, 2:48 PM
atul edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Jun 4 2024, 2:41 AM

Safe to land in isolation since it's a simple rename.

In D12296#350101, @atul wrote:

Safe to land in isolation since it's a simple rename.

JK, there are merge conflicts so not worth it. Simple to resolve, but would rather defer.

This revision was landed with ongoing or failed builds.Jun 17 2024, 5:39 PM
This revision was automatically updated to reflect the committed changes.