Page MenuHomePhabricator
Differential D12296

[lib] Rename `MemberInfo` to `MemberInfoWithPermissions`
ClosedPublic
Actions

Authored by atul on Mon, Jun 3, 2:41 PM.
Tags
None
Referenced Files
F2127566: D12296.diff
Thu, Jun 27, 8:05 AM
F2125843: D12296.id41420.diff
Thu, Jun 27, 2:54 AM
Unknown Object (File)
Tue, Jun 25, 8:51 PM
Unknown Object (File)
Tue, Jun 25, 1:32 AM
Unknown Object (File)
Tue, Jun 25, 12:31 AM
Unknown Object (File)
Mon, Jun 24, 2:49 AM
Unknown Object (File)
Fri, Jun 21, 6:43 AM
Unknown Object (File)
Fri, Jun 21, 6:23 AM
View All 29 Files
Subscribers
None

Details

Reviewers
ashoat
ginsu
tomek
varun
Commits
rCOMMbcd2ea0419e5: [lib] Rename `MemberInfo` to `MemberInfoWithPermissions`
Summary

This is to make room for MemberInfoWithoutPermissions or MemberInfoSansPermissions, etc.

We're going to need both in different places in the codebase. Specifically we'll definitely need MemberInfoWithPermissions when constructing RawThreadInfos for old clients, etc.

The goal at the end of the stack is for the client to only deal with MemberInfoSansPermissions.

Will try to make the changes as minimal as possible...

Depends on D12295

Test Plan

flow/NA just a simple rename

Diff Detail

Repository
rCOMM Comm
Branch
master
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Mon, Jun 3, 2:41 PM
atul updated this revision to Diff 40906.Mon, Jun 3, 2:48 PM

include validator rename

atul published this revision for review.Mon, Jun 3, 2:48 PM
atul edited the summary of this revision. (Show Details)
Harbormaster completed remote builds in B29404: Diff 40905.Mon, Jun 3, 2:58 PM
Harbormaster completed remote builds in B29405: Diff 40906.Mon, Jun 3, 3:04 PM
tomek accepted this revision.Tue, Jun 4, 2:41 AM
This revision is now accepted and ready to land.Tue, Jun 4, 2:41 AM
ashoat accepted this revision.Tue, Jun 4, 11:44 AM
atul updated this revision to Diff 40973.Tue, Jun 4, 2:08 PM

cherry-pick

atul added a comment.Tue, Jun 4, 2:09 PM

Safe to land in isolation since it's a simple rename.

atul added a comment.Tue, Jun 4, 2:12 PM
In D12296#350101, @atul wrote:

Safe to land in isolation since it's a simple rename.

JK, there are merge conflicts so not worth it. Simple to resolve, but would rather defer.

Harbormaster completed remote builds in B29444: Diff 40973.Tue, Jun 4, 2:25 PM
atul added a child revision: D12315: [lib] Introduce `MemberInfoSansPermissions`.Tue, Jun 4, 2:29 PM
atul updated this revision to Diff 41420.Mon, Jun 17, 4:33 PM

amend

Harbormaster completed remote builds in B29727: Diff 41420.Mon, Jun 17, 4:49 PM
atul updated this revision to Diff 41421.Mon, Jun 17, 5:38 PM

land

This revision was landed with ongoing or failed builds.Mon, Jun 17, 5:39 PM
Closed by commit rCOMMbcd2ea0419e5: [lib] Rename `MemberInfo` to `MemberInfoWithPermissions` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMMbcd2ea0419e5: [lib] Rename `MemberInfo` to `MemberInfoWithPermissions`.
Harbormaster completed remote builds in B29728: Diff 41421.Mon, Jun 17, 5:55 PM

Revision Contents
Changeset List

Diff 40905

View Options

lib/permissions/minimally-encoded-raw-thread-info-validators.js

Loading...
View Options

lib/shared/thread-utils.js

Loading...
View Options

lib/types/minimally-encoded-thread-permissions-types.js

Loading...
View Options

lib/utils/thread-ops-utils.js

Loading...