Page MenuHomePhabricator
Differential D12416

[reports] Require auth for viewing reports
ClosedPublic
Actions

Authored by bartek on Thu, Jun 13, 1:10 AM.
Tags
None
Referenced Files
F2122818: D12416.diff
Wed, Jun 26, 5:58 PM
F2120884: D12416.id41271.diff
Wed, Jun 26, 3:22 PM
F2116987: D12416.id.diff
Wed, Jun 26, 10:11 AM
Unknown Object (File)
Mon, Jun 24, 7:12 PM
Unknown Object (File)
Mon, Jun 24, 4:07 PM
Unknown Object (File)
Mon, Jun 24, 9:44 AM
Unknown Object (File)
Sun, Jun 23, 3:45 PM
Unknown Object (File)
Sun, Jun 23, 10:55 AM
View All 19 Files
Subscribers
ashoat
tomek

Details

Reviewers
will
varun
kamil
Commits
rCOMMc459cea60ff1: [reports] Require auth for viewing reports
Summary

Wrapped viewing reports endpoints with auth middleware.
The POST /reports still works without auth - it is optional there and used only for retrieving user_id.

Depends on D12415

Test Plan
  • Repeated test plan from D12414 for /reports endpoints.
  • Verified that sending reports still works without auth.
  • Verified that user_id is present when sending reports with valid credentials.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Thu, Jun 13, 1:10 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Jun 13, 1:10 AM
bartek added a child revision: D12417: [terraform] Disable CSAT verification on prod.Thu, Jun 13, 1:25 AM
Harbormaster failed remote builds in B29643: Diff 41266!Thu, Jun 13, 1:30 AM
bartek updated this revision to Diff 41271.Thu, Jun 13, 1:55 AM

Rebase

Harbormaster completed remote builds in B29648: Diff 41271.Thu, Jun 13, 2:11 AM
bartek published this revision for review.Thu, Jun 13, 2:12 AM
ashoat added a comment.Thu, Jun 13, 8:23 AM

Heads-up, there are no reviewers specified here

bartek added reviewers: will, varun, kamil.Thu, Jun 13, 8:39 AM
bartek added a child revision: D12448: [reports] Verify CSAT if present.Mon, Jun 17, 3:49 AM
bartek removed a child revision: D12417: [terraform] Disable CSAT verification on prod.Mon, Jun 17, 3:51 AM
varun accepted this revision.Mon, Jun 17, 9:01 PM
This revision is now accepted and ready to land.Mon, Jun 17, 9:01 PM
Closed by commit rCOMMc459cea60ff1: [reports] Require auth for viewing reports (authored by bartek). · Explain WhyTue, Jun 18, 2:19 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMc459cea60ff1: [reports] Require auth for viewing reports.

Revision Contents
Changeset List

PathSize
services/
reports/
src/
http/
7 lines

Diff 41266

View Options

services/reports/src/http/handlers.rs

Loading...