Page MenuHomePhabricator

[backup] Hotfix Blob service client auth
ClosedPublic

Authored by bartek on Jun 20 2024, 1:11 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 2, 3:41 AM
Unknown Object (File)
Fri, Nov 1, 2:26 PM
Unknown Object (File)
Fri, Nov 1, 1:20 PM
Unknown Object (File)
Wed, Oct 30, 8:58 AM
Unknown Object (File)
Fri, Oct 25, 1:04 AM
Unknown Object (File)
Thu, Oct 24, 10:06 PM
Unknown Object (File)
Tue, Oct 22, 4:14 AM
Unknown Object (File)
Sat, Oct 19, 3:38 AM
Subscribers

Details

Summary

Noticed that Backup service had code respoinsible for extracting UserIdentity (auth metadata),
but it was never supplied to BlobServiceClient so Backup -> Blob service requests were unauthenticated.

This is not the nicest solution but it works. A proper solution will be introduced in the next diffs.

Test Plan

Backup service on staging

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.Jun 20 2024, 1:39 AM
bartek added inline comments.
services/backup/src/http/handlers/backup.rs
309–322 ↗(On Diff #41541)

This endpoint is unauthenticated so we need to get a service-to-service token.
This is not nice (very verbose) but I'll refactor it in the next diffs

This revision is now accepted and ready to land.Jun 20 2024, 3:37 AM
This revision was automatically updated to reflect the committed changes.