Page MenuHomePhabricator
Differential D12504

[backup] Hotfix Blob service client auth
ClosedPublic
Actions

Authored by bartek on Jun 20 2024, 1:11 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Sep 10, 8:30 AM
Unknown Object (File)
Tue, Sep 10, 5:10 AM
Unknown Object (File)
Mon, Sep 9, 5:26 PM
Unknown Object (File)
Mon, Sep 9, 11:17 AM
Unknown Object (File)
Thu, Sep 5, 2:34 AM
Unknown Object (File)
Wed, Sep 4, 4:28 AM
Unknown Object (File)
Wed, Sep 4, 2:03 AM
Unknown Object (File)
Tue, Sep 3, 11:23 PM
View All 54 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
Commits
rCOMM44ecf8804a94: [backup] Hotfix Blob service client auth
Summary

Noticed that Backup service had code respoinsible for extracting UserIdentity (auth metadata),
but it was never supplied to BlobServiceClient so Backup -> Blob service requests were unauthenticated.

This is not the nicest solution but it works. A proper solution will be introduced in the next diffs.

Test Plan

Backup service on staging

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Jun 20 2024, 1:11 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 20 2024, 1:11 AM
bartek added a child revision: D12505: [terraform] Add IAM policies for services-to-services token.Jun 20 2024, 1:14 AM
Harbormaster completed remote builds in B29809: Diff 41541.Jun 20 2024, 1:28 AM
bartek published this revision for review.Jun 20 2024, 1:39 AM
bartek added inline comments.
services/backup/src/http/handlers/backup.rs
309–322 ↗(On Diff #41541)

This endpoint is unauthenticated so we need to get a service-to-service token.
This is not nice (very verbose) but I'll refactor it in the next diffs

bartek added a child revision: D12506: [comm-lib] Implement FromRequest for AuthService.Jun 20 2024, 2:22 AM
kamil accepted this revision.Jun 20 2024, 3:37 AM
This revision is now accepted and ready to land.Jun 20 2024, 3:37 AM
Closed by commit rCOMM44ecf8804a94: [backup] Hotfix Blob service client auth (authored by bartek). · Explain WhyJun 20 2024, 4:52 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM44ecf8804a94: [backup] Hotfix Blob service client auth.

Revision Contents
Changeset List

PathSize
services/
backup/
src/
7 lines
http/
handlers/
29 lines
2 lines

Diff 41561

View Options

services/backup/src/error.rs

Loading...
View Options

services/backup/src/http/handlers/backup.rs

Loading...
View Options

services/backup/src/http/handlers/log.rs

Loading...