[backup][backup-client] Add auth to logs websocket
ClosedPublic
Actions

Authored by bartek on Jun 20 2024, 4:56 AM.

Details

Reviewers

marcin
varun
will
kamil

Commits

rCOMMd58e8906fc2d: [backup][backup-client] Add auth to logs websocket

Summary

Addresses 3 in ENG-8473.

Added LogWSResponse::AuthSuccess
Modified backup service handler to verify passed UserIdentity
Modified backup client to wait for AuthSuccess message after sending auth request.

Depends on D12508

Test Plan

Backup integration tests. Added some logging.
Also tested with COMM_SERVICES_SKIP_CSAT_VERIFICATION - auth message is still required but verification always succeeds.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jun 20 2024, 4:56 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 20 2024, 4:56 AM

Harbormaster completed remote builds in B29829: Diff 41565.Jun 20 2024, 5:25 AM

bartek published this revision for review.Jun 20 2024, 7:19 AM

bartek added inline comments.

services/backup/src/http/handlers/log.rs
61 ↗	(On Diff #41565)	Unfortunately we need this to modify this `Option` from spawned future and read it in the sync fn. Technically, they're not going block by each other but we need to do it for safety.