Page MenuHomePhabricator
Differential D12506

[comm-lib] Implement FromRequest for AuthService
ClosedPublic
Actions

Authored by bartek on Jun 20 2024, 2:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 6, 12:12 AM
Unknown Object (File)
Thu, Mar 20, 1:43 AM
Unknown Object (File)
Fri, Mar 14, 5:33 AM
Unknown Object (File)
Mar 3 2025, 2:31 PM
Unknown Object (File)
Feb 28 2025, 12:09 AM
Unknown Object (File)
Feb 28 2025, 12:09 AM
Unknown Object (File)
Feb 28 2025, 12:08 AM
Unknown Object (File)
Feb 26 2025, 9:27 AM
View All 58 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
varun
will
Commits
rCOMM8a4928e1ee25: [comm-lib] Implement FromRequest for AuthService
Summary

Extracted code that retrieves AuthService into a dedicated trait implementation.
Inspired by the web::Data counterpart.

Depends on D12504

Test Plan

Local backup and reports services. Commenting out .app_data(auth_service) from http/mod causes
the error message to be printed.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
services/
backup/
src/
http/
handlers/
8 lines
reports/
src/
http/
14 lines
shared/
comm-lib/
src/
http/
21 lines

Diff 41703

View Options

services/backup/src/http/handlers/backup.rs

Show First 20 Lines • Show All 1,660 Lines • ▼ Show 20 LinesCommCoreModule::restoreBackup(jsi::Runtime &rt, jsi::String backupSecret) {
std::string backupSecretStr = backupSecret.utf8(rt); std::string backupSecretStr = backupSecret.utf8(rt);
return createPromiseAsJSIValue( return createPromiseAsJSIValue(
rt, [=](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) { rt, [=](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
auto currentID = RustPromiseManager::instance.addPromise( auto currentID = RustPromiseManager::instance.addPromise(
{promise, this->jsInvoker_, innerRt}); {promise, this->jsInvoker_, innerRt});
::restoreBackup(rust::string(backupSecretStr), currentID); ::restoreBackup(rust::string(backupSecretStr), currentID);
}); });
} }
jsi::Value CommCoreModule::restoreBackupData(
jsi::Runtime &rt,
jsi::String backupID,
jsi::String backupDataKey,
jsi::String backupLogDataKey) {
std::string backupIDStr = backupID.utf8(rt);
std::string backupDataKeyStr = backupDataKey.utf8(rt);
std::string backupLogDataKeyStr = backupLogDataKey.utf8(rt);
return createPromiseAsJSIValue(
rt, [=](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
auto currentID = RustPromiseManager::instance.addPromise(
{promise, this->jsInvoker_, innerRt});
::restoreBackupData(
rust::string(backupIDStr),
rust::string(backupDataKeyStr),
rust::string(backupLogDataKeyStr),
currentID);
});
}
jsi::Value
CommCoreModule::retrieveBackupKeys(jsi::Runtime &rt, jsi::String backupSecret) {
std::string backupSecretStr = backupSecret.utf8(rt);
return createPromiseAsJSIValue(
rt, [=](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
auto currentID = RustPromiseManager::instance.addPromise(
{promise, this->jsInvoker_, innerRt});
::retrieveBackupKeys(rust::string(backupSecretStr), currentID);
});
}
} // namespace comm } // namespace comm
View Options

services/reports/src/http/service.rs

Show First 20 Lines • Show All 1,660 Lines • ▼ Show 20 LinesCommCoreModule::restoreBackup(jsi::Runtime &rt, jsi::String backupSecret) {
std::string backupSecretStr = backupSecret.utf8(rt); std::string backupSecretStr = backupSecret.utf8(rt);
return createPromiseAsJSIValue( return createPromiseAsJSIValue(
rt, [=](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) { rt, [=](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
auto currentID = RustPromiseManager::instance.addPromise( auto currentID = RustPromiseManager::instance.addPromise(
{promise, this->jsInvoker_, innerRt}); {promise, this->jsInvoker_, innerRt});
::restoreBackup(rust::string(backupSecretStr), currentID); ::restoreBackup(rust::string(backupSecretStr), currentID);
}); });
} }
jsi::Value CommCoreModule::restoreBackupData(
jsi::Runtime &rt,
jsi::String backupID,
jsi::String backupDataKey,
jsi::String backupLogDataKey) {
std::string backupIDStr = backupID.utf8(rt);
std::string backupDataKeyStr = backupDataKey.utf8(rt);
std::string backupLogDataKeyStr = backupLogDataKey.utf8(rt);
return createPromiseAsJSIValue(
rt, [=](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
auto currentID = RustPromiseManager::instance.addPromise(
{promise, this->jsInvoker_, innerRt});
::restoreBackupData(
rust::string(backupIDStr),
rust::string(backupDataKeyStr),
rust::string(backupLogDataKeyStr),
currentID);
});
}
jsi::Value
CommCoreModule::retrieveBackupKeys(jsi::Runtime &rt, jsi::String backupSecret) {
std::string backupSecretStr = backupSecret.utf8(rt);
return createPromiseAsJSIValue(
rt, [=](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
auto currentID = RustPromiseManager::instance.addPromise(
{promise, this->jsInvoker_, innerRt});
::retrieveBackupKeys(rust::string(backupSecretStr), currentID);
});
}
} // namespace comm } // namespace comm
View Options

shared/comm-lib/src/http/auth.rs

Show First 20 Lines • Show All 1,660 Lines • ▼ Show 20 LinesCommCoreModule::restoreBackup(jsi::Runtime &rt, jsi::String backupSecret) {
std::string backupSecretStr = backupSecret.utf8(rt); std::string backupSecretStr = backupSecret.utf8(rt);
return createPromiseAsJSIValue( return createPromiseAsJSIValue(
rt, [=](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) { rt, [=](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
auto currentID = RustPromiseManager::instance.addPromise( auto currentID = RustPromiseManager::instance.addPromise(
{promise, this->jsInvoker_, innerRt}); {promise, this->jsInvoker_, innerRt});
::restoreBackup(rust::string(backupSecretStr), currentID); ::restoreBackup(rust::string(backupSecretStr), currentID);
}); });
} }
jsi::Value CommCoreModule::restoreBackupData(
jsi::Runtime &rt,
jsi::String backupID,
jsi::String backupDataKey,
jsi::String backupLogDataKey) {
std::string backupIDStr = backupID.utf8(rt);
std::string backupDataKeyStr = backupDataKey.utf8(rt);
std::string backupLogDataKeyStr = backupLogDataKey.utf8(rt);
return createPromiseAsJSIValue(
rt, [=](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
auto currentID = RustPromiseManager::instance.addPromise(
{promise, this->jsInvoker_, innerRt});
::restoreBackupData(
rust::string(backupIDStr),
rust::string(backupDataKeyStr),
rust::string(backupLogDataKeyStr),
currentID);
});
}
jsi::Value
CommCoreModule::retrieveBackupKeys(jsi::Runtime &rt, jsi::String backupSecret) {
std::string backupSecretStr = backupSecret.utf8(rt);
return createPromiseAsJSIValue(
rt, [=](jsi::Runtime &innerRt, std::shared_ptr<Promise> promise) {
auto currentID = RustPromiseManager::instance.addPromise(
{promise, this->jsInvoker_, innerRt});
::retrieveBackupKeys(rust::string(backupSecretStr), currentID);
});
}
} // namespace comm } // namespace comm