Page MenuHomePhabricator
Differential D12523

[Tunnelbroker] handle `SetDeviceToken` message
ClosedPublic
Actions

Authored by kamil on Jun 20 2024, 2:54 PM.
Tags
None
Referenced Files
F3345940: D12523.diff
Fri, Nov 22, 7:36 AM
Unknown Object (File)
Thu, Nov 21, 1:58 AM
Unknown Object (File)
Fri, Nov 8, 10:36 PM
Unknown Object (File)
Fri, Nov 8, 1:30 PM
Unknown Object (File)
Fri, Nov 8, 12:24 PM
Unknown Object (File)
Tue, Nov 5, 2:57 AM
Unknown Object (File)
Oct 22 2024, 1:17 PM
Unknown Object (File)
Oct 22 2024, 8:35 AM
View All 56 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
marcin
Commits
rCOMM36a8f028c429: [Tunnelbroker] handle `SetDeviceToken` message
Summary

ENG-8347

Code to handle message from the client.

Depends on D12520, D12522

Test Plan

Tested in next diff

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Jun 20 2024, 2:54 PM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 20 2024, 2:54 PM
kamil added a child revision: D12524: [lib] implement sending message to Tunnelbroker.Jun 20 2024, 2:55 PM
Harbormaster failed remote builds in B29845: Diff 41580!Jun 20 2024, 3:00 PM
kamil published this revision for review.Jun 20 2024, 4:12 PM
Harbormaster completed remote builds in B29845: Diff 41580.Jun 20 2024, 4:28 PM
bartek accepted this revision.Jun 21 2024, 11:11 PM
bartek added inline comments.
services/tunnelbroker/src/websockets/session.rs
327–329

I guess the type can be inferred from handle_message_to_tunnelbroker() call below

338–341

Wondering why we're using Option::from() everywhere. Simple Some() would work too

This revision is now accepted and ready to land.Jun 21 2024, 11:11 PM
kamil updated this revision to Diff 41801.Jun 28 2024, 6:17 AM

address nits

Harbormaster completed remote builds in B29997: Diff 41801.Jun 28 2024, 6:34 AM
Closed by commit rCOMM36a8f028c429: [Tunnelbroker] handle `SetDeviceToken` message (authored by kamil). · Explain WhyJun 28 2024, 6:48 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM36a8f028c429: [Tunnelbroker] handle `SetDeviceToken` message.

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
src/
websockets/
47 lines

Diff 41580

View Options

services/tunnelbroker/src/websockets/session.rs

Loading...