[lib] implement sending message to Tunnelbroker
ClosedPublic
Actions

Authored by kamil on Jun 20 2024, 2:55 PM.

Details

Reviewers

bartek
marcin

Commits

rCOMM166dc76c6518: [lib] implement sending message to Tunnelbroker

Summary

ENG-8347

Add callback to send message to Tunnelbroker.

Depends on D12523

Test Plan

Call this from both web and native:

const message: SetDeviceToken = {
  type: messageToTunnelbrokerTypes.SET_DEVICE_TOKEN,
  deviceToken: 'token',
};
 await sendMessageToTunnelbroker(JSON.stringify(message));

and verify if deviceToken is persisted in DDB.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jun 20 2024, 2:55 PM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 20 2024, 2:55 PM

Harbormaster completed remote builds in B29846: Diff 41581.Jun 20 2024, 3:15 PM

kamil published this revision for review.Jun 20 2024, 4:13 PM

kamil added a child revision: D12538: [lib] introduce Tunnelbroker device token handler.Jun 21 2024, 2:45 AM

bartek added inline comments.Jun 21 2024, 11:19 PM

lib/tunnelbroker/tunnelbroker-context.js
363–364 ↗	(On Diff #41581)	Leftover?

remove debug

kamil added inline comments.Jun 24 2024, 3:26 AM

lib/tunnelbroker/tunnelbroker-context.js
363–364 ↗	(On Diff #41581)	yeah

Harbormaster completed remote builds in B29893: Diff 41637.Jun 24 2024, 3:45 AM

bartek accepted this revision.Jun 24 2024, 11:44 PM

This revision is now accepted and ready to land.Jun 24 2024, 11:44 PM

rebase before landing

Harbormaster completed remote builds in B29998: Diff 41802.Jun 28 2024, 6:39 AM

Closed by commit rCOMM166dc76c6518: [lib] implement sending message to Tunnelbroker (authored by kamil). · Explain WhyJun 28 2024, 6:48 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM166dc76c6518: [lib] implement sending message to Tunnelbroker.

ashoat added inline comments.Jul 1 2024, 1:30 PM

lib/tunnelbroker/tunnelbroker-context.js
437–438	The naming here is a bit confusing. Should `sendMessage` be renamed to something that makes it contrast more clearly with `sendMessageToTunnelbroker`?