Page MenuHomePhabricator
Differential D12546

[web] inform password users that they need to log in from native to claim username
ClosedPublic
Actions

Authored by varun on Jun 21 2024, 4:46 PM.
Tags
None
Referenced Files
F3248477: D12546.diff
Fri, Nov 15, 10:00 AM
Unknown Object (File)
Sat, Nov 9, 6:48 AM
Unknown Object (File)
Sun, Oct 27, 1:20 AM
Unknown Object (File)
Oct 12 2024, 3:11 PM
Unknown Object (File)
Oct 12 2024, 3:11 PM
Unknown Object (File)
Oct 12 2024, 3:10 PM
Unknown Object (File)
Oct 12 2024, 3:10 PM
Unknown Object (File)
Oct 10 2024, 9:13 PM
View All 41 Files
Subscribers
ashoat
tomek

Details

Reviewers
inka
ginsu
Commits
rCOMM99e7643512ed: [web] inform password users that they need to log in from native to claim…
Summary

Depends on D12545

this is similar to the previous diff but for password users

Test Plan

tried logging in from web with a reserved username and got the expected error message

Screenshot 2024-06-21 at 5.17.30 PM.png (1×1 px, 114 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Jun 21 2024, 4:46 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 21 2024, 4:46 PM
varun edited the summary of this revision. (Show Details)Jun 21 2024, 4:46 PM
varun added a parent revision: D12545: [web] handle case where user needs to log in from native first.
varun removed a parent revision: D12544: [identity] fix reserved username workflow for wallet users.
varun added a child revision: D12547: remove reserved wallet registration RPC.Jun 21 2024, 4:48 PM
Harbormaster completed remote builds in B29884: Diff 41628.Jun 21 2024, 5:02 PM
varun requested review of this revision.Jun 21 2024, 5:02 PM
varun edited the test plan for this revision. (Show Details)Jun 21 2024, 5:14 PM
varun attached a referenced file: F2068619: Screenshot 2024-06-21 at 5.17.30 PM.png. (Show Details)

i'll try to shorten the message so it fits on one line. looks a little janky rn

inka added a comment.Jun 24 2024, 12:32 AM

Why would a user be claiming a username from login screen? Isn't claiming username registration?

varun added a comment.Jun 24 2024, 6:49 AM
In D12546#355463, @inka wrote:

Why would a user be claiming a username from login screen? Isn't claiming username registration?

User A registers directly with Ashoat’s keyserver. Then we flip the usingCSAT switch. The next time A tries to log in from native, we register them with identity transparently

ginsu accepted this revision.Jun 24 2024, 10:16 AM

Looks good, but is there a follow up task/diff to address the janky ui?

This revision is now accepted and ready to land.Jun 24 2024, 10:16 AM
varun added a comment.Jun 24 2024, 10:17 AM
In D12546#355540, @ginsu wrote:

Looks good, but is there a follow up task/diff to address the janky ui?

I'm just going to shorten the message before landing to 'please log in from a mobile device then retry' so that it fits on one line

Closed by commit rCOMM99e7643512ed: [web] inform password users that they need to log in from native to claim… (authored by varun). · Explain WhyJun 24 2024, 10:29 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMM99e7643512ed: [web] inform password users that they need to log in from native to claim….

Revision Contents
Changeset List

PathSize
web/
account/
6 lines

Diff 41654

View Options

web/account/traditional-login-form.react.js

Loading...