Details

Reviewers

inka
kamil
ashoat

Commits

rCOMMd5fc6c85644a: [web] add Tag Farcaster channel option to CommunityActionsMenu

Summary

This diff simply adds the Tag Farcaster channel option to the CommunityActionsMenu if the conditions are met (user has fid, they have the necessary permissions, and the community is not a GENESIS community)

Depends on D12567

Test Plan

Confirmed that this option is only present if the conditions mentioned above are met. Also please see screenshot below

Screenshot 2024-06-25 at 2.24.56 AM.png (534×746 px, 38 KB)

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Jun 24 2024, 11:22 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 24 2024, 11:22 PM

ginsu edited the summary of this revision. (Show Details)Jun 24 2024, 11:31 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: inka, kamil.

ginsu added a parent revision: D12567: [web] introduce tagFarcasterChannelByName to CreateFarcasterChannelTagModal.

ginsu attached a referenced file: F2102051: Screenshot 2024-06-25 at 2.24.56 AM.png. (Show Details)

This diff contains copy that needs to be reviewed

web/components/community-actions-menu.react.js
109 ↗	(On Diff #41676)	This copy needs to be reviewed
110 ↗	(On Diff #41676)	Not sure if this icon is good, but it felt like the best one from the SWM icon pack https://www.figma.com/design/wGdM1Yajw9nUS0HU0OYorC/SWM-Icon-Pack-(Community)?node-id=202-304&t=XdortD2fRM1PZV4N-1

Harbormaster completed remote builds in B29916: Diff 41676.Jun 24 2024, 11:39 PM

ginsu requested review of this revision.Jun 24 2024, 11:39 PM

ginsu added a child revision: D12569: [lib/web] introduce handleCurrentUserFID to FarcasterDataHandler.Jun 24 2024, 11:48 PM

inka accepted this revision.Jun 27 2024, 6:53 AM

Passing back to factor out the check. We should avoid copy-pasting code, especially when it's related to things like permissions. It makes it way more likely that somebody fails to update some copy-pasted conditional at a later point

web/components/community-actions-menu.react.js
55–58 ↗	(On Diff #41676)	Does this check exist anywhere else, eg. `native`? If so, can you factor it out please?
110 ↗	(On Diff #41676)	Do we have a similar need for an icon on `native`, and if so what icon we're using?

This revision now requires changes to proceed.Jun 27 2024, 1:20 PM

address comments

ginsu added inline comments.Jun 30 2024, 8:12 PM

web/components/community-actions-menu.react.js
110 ↗	(On Diff #41676)	On `native` we use an action sheet and none of the options use an icon https://github.com/CommE2E/comm/blob/master/native/components/community-actions-button.react.js#L157-L177