Page MenuHomePhabricator
Differential D12609

[Tunnelbroker] implement APNs config
Needs RevisionPublic
Actions

Authored by kamil on Fri, Jun 28, 4:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 29, 12:47 AM
Unknown Object (File)
Sat, Jun 29, 12:47 AM
Unknown Object (File)
Sat, Jun 29, 12:46 AM
Subscribers
ashoat
tomek

Details

Reviewers
bartek
marcin
Summary

Config to APNs similar to keyserver, but instead of reading private key from the file we pass it inside JSON (command line or AWS KMS secrets).

Keyserver config: link.

Depends on D12608

Test Plan
  1. Add config var from commandline and log it
  2. For staging (using env::var) going to test after deploying

Diff Detail

Repository
rCOMM Comm
Branch
apns-tb
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Fri, Jun 28, 4:25 AM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptFri, Jun 28, 4:25 AM
Harbormaster completed remote builds in B29987: Diff 41786.Fri, Jun 28, 4:41 AM
kamil added a child revision: D12610: [Tunnelbroker] implement APNs Token generation and lifetime.Fri, Jun 28, 4:46 AM
kamil published this revision for review.Fri, Jun 28, 6:24 AM
kamil edited the summary of this revision. (Show Details)
bartek requested changes to this revision.Mon, Jul 1, 1:58 AM

Can we either?:

  • Fully rely on clap parsing the env variable
  • Remove the env support in clap
services/tunnelbroker/src/config.rs
31
  1. This code means you can pass either --apns-config CLI param or env variable named "ENV_APNS_CONFIG".
  2. Separately you have crate::constants::ENV_APNS_CONFIG (which has value "APNS_CONFIG") and you're parsing it below (manually without clap).

If you go with 2 only, you can remove this line

services/tunnelbroker/src/main.rs
36–42

If you rely on clap parsing the env var, this shouldn't be necessary, #[arg(env = ENV_APNS_CONFIG)] should handle it for you

This revision now requires changes to proceed.Mon, Jul 1, 1:59 AM

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
src/
5 lines
12 lines
notifs/
apns/
18 lines
2 lines

Diff 41786

View Options

services/tunnelbroker/src/config.rs

Loading...
View Options

services/tunnelbroker/src/main.rs

Loading...
View Options

services/tunnelbroker/src/notifs/apns/config.rs

Loading...
View Options

services/tunnelbroker/src/notifs/apns/mod.rs

Loading...