Details
Details
- Reviewers
bartek marcin - Commits
- rCOMM48b881f7b7e3: [Tunnelbroker] implement APNs config
- Add config var from commandline and log it
- For staging (using env::var) going to test after deploying
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Can we either?:
- Fully rely on clap parsing the env variable
- Remove the env support in clap
services/tunnelbroker/src/config.rs | ||
---|---|---|
31 ↗ | (On Diff #41786) |
If you go with 2 only, you can remove this line |
services/tunnelbroker/src/main.rs | ||
36–42 ↗ | (On Diff #41786) | If you rely on clap parsing the env var, this shouldn't be necessary, #[arg(env = ENV_APNS_CONFIG)] should handle it for you |
Comment Actions
Thanks, @bartek, update to rely on clap.
Tested both:
cargo run -- --apns-config '{"key":"your_key_here","keyId":"your_key_id_here","teamId":"your_team_id_here","production":true}'
and
APNS_CONFIG='{"key":"your_key_here","keyId":"your_key_id_here","teamId":"your_team_id_here","production":true}' cargo run