Page MenuHomePhabricator
Differential D12610

[Tunnelbroker] implement APNs Token generation and lifetime
ClosedPublic
Actions

Authored by kamil on Fri, Jun 28, 4:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 29, 12:47 AM
Unknown Object (File)
Sat, Jun 29, 12:47 AM
Unknown Object (File)
Sat, Jun 29, 12:47 AM
Unknown Object (File)
Sat, Jun 29, 12:46 AM
Subscribers
ashoat
tomek

Details

Reviewers
bartek
marcin
Commits
rCOMM228893b1fd5a: [Tunnelbroker] implement APNs Token generation and lifetime
Summary

Implementing what is described in Apple's Establishing a token-based connection to APNs.

Config in tests is randomly generated.

Depends on D12609

Test Plan

Tests, later in the task tested actual communication with APNs.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Fri, Jun 28, 4:46 AM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptFri, Jun 28, 4:46 AM
Harbormaster failed remote builds in B29988: Diff 41787!Fri, Jun 28, 4:53 AM
kamil updated this revision to Diff 41788.Fri, Jun 28, 5:00 AM

fix typo

kamil added a child revision: D12611: [Tunnelbroker] implement creating APNs client.Fri, Jun 28, 5:00 AM
Harbormaster completed remote builds in B29989: Diff 41788.Fri, Jun 28, 5:16 AM
kamil mentioned this in D12607: [Tunnelbroker] add `jsonwebtoken` dependency.Fri, Jun 28, 6:22 AM
kamil published this revision for review.Fri, Jun 28, 6:26 AM
kamil added inline comments.
services/tunnelbroker/src/notifs/apns/token.rs
83 ↗(On Diff #41788)

Apple key is in PKCS#8 form.

bartek accepted this revision.Mon, Jul 1, 2:08 AM

Nice job with the Arc<RwLock>!

services/tunnelbroker/src/notifs/apns/token.rs
6 ↗(On Diff #41788)

Up to you, but we have the chrono crate which might be more handy.
Not worth changing though, std::time works well too, I just find it a bit less convenient

This revision is now accepted and ready to land.Mon, Jul 1, 2:08 AM
kamil added a child revision: D12635: [Tunnelbroker] implement creating APNs client.Tue, Jul 2, 4:07 AM
Closed by commit rCOMM228893b1fd5a: [Tunnelbroker] implement APNs Token generation and lifetime (authored by kamil). · Explain WhyTue, Jul 2, 8:35 AM
This revision was automatically updated to reflect the committed changes.
kamil mentioned this in rCOMMc36192b438fe: [Tunnelbroker] add `jsonwebtoken` dependency.
kamil added a commit: rCOMM228893b1fd5a: [Tunnelbroker] implement APNs Token generation and lifetime.

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
src/
notifs/
apns/
12 lines
5 lines
147 lines

Diff 41891

View Options

services/tunnelbroker/src/notifs/apns/error.rs

Loading...
View Options

services/tunnelbroker/src/notifs/apns/mod.rs

Loading...
View Options

services/tunnelbroker/src/notifs/apns/token.rs

Loading...