Paths

Table of Contentst

Differential D12610

[Tunnelbroker] implement APNs Token generation and lifetime
ClosedPublic
Actions

Authored by kamil on Jun 28 2024, 4:46 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 22, 8:54 PM

	Unknown Object (File)
	Tue, Nov 12, 3:12 PM

	Unknown Object (File)
	Tue, Nov 12, 2:52 PM

	Unknown Object (File)
	Tue, Nov 12, 2:26 PM

	Unknown Object (File)
	Tue, Nov 12, 1:03 PM

	Unknown Object (File)
	Tue, Nov 12, 12:56 PM

	Unknown Object (File)
	Tue, Nov 12, 11:48 AM

	Unknown Object (File)
	Tue, Nov 12, 10:50 AM

View All 57 Files

Subscribers

Details

Reviewers

bartek
marcin

Commits

rCOMM228893b1fd5a: [Tunnelbroker] implement APNs Token generation and lifetime

Summary

Implementing what is described in Apple's Establishing a token-based connection to APNs.

Config in tests is randomly generated.

Depends on D12609

Test Plan

Tests, later in the task tested actual communication with APNs.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jun 28 2024, 4:46 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 28 2024, 4:46 AM

Harbormaster failed remote builds in B29988: Diff 41787!Jun 28 2024, 4:53 AM

fix typo

kamil added a child revision: D12611: [Tunnelbroker] implement creating APNs client.Jun 28 2024, 5:00 AM

Harbormaster completed remote builds in B29989: Diff 41788.Jun 28 2024, 5:16 AM

kamil mentioned this in D12607: [Tunnelbroker] add `jsonwebtoken` dependency.Jun 28 2024, 6:22 AM

kamil published this revision for review.Jun 28 2024, 6:26 AM

kamil added inline comments.

services/tunnelbroker/src/notifs/apns/token.rs
83 ↗	(On Diff #41788)	Apple key is in `PKCS#8` form.

Nice job with the Arc<RwLock>!

services/tunnelbroker/src/notifs/apns/token.rs
6 ↗	(On Diff #41788)	Up to you, but we have the `chrono` crate which might be more handy. Not worth changing though, `std::time` works well too, I just find it a bit less convenient

This revision is now accepted and ready to land.Jul 1 2024, 2:08 AM

kamil added a child revision: D12635: [Tunnelbroker] implement creating APNs client.Jul 2 2024, 4:07 AM

Closed by commit rCOMM228893b1fd5a: [Tunnelbroker] implement APNs Token generation and lifetime (authored by kamil). · Explain WhyJul 2 2024, 8:35 AM

This revision was automatically updated to reflect the committed changes.

kamil mentioned this in rCOMMc36192b438fe: [Tunnelbroker] add `jsonwebtoken` dependency.

kamil added a commit: rCOMM228893b1fd5a: [Tunnelbroker] implement APNs Token generation and lifetime.

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

src/

notifs/

apns/

12 lines

5 lines

147 lines

Diff 41891

services/tunnelbroker/src/notifs/apns/error.rs

Loading...

services/tunnelbroker/src/notifs/apns/mod.rs

Loading...

services/tunnelbroker/src/notifs/apns/token.rs

Loading...