[Tunnelbroker] implement sending APNs notif
ClosedPublic
Actions

Authored by kamil on Jun 28 2024, 12:37 PM.

Details

Reviewers

bartek
marcin

Commits

rCOMMf71495b1458b: [Tunnelbroker] implement sending APNs notif

Summary

Sending notif according APNs docs.

Depends on D12613

Test Plan

Implement a couple tests and ran locally to call this function (using device token of my personal iOS device) and this notif:

let payload = json!({
    "aps" : {
        "alert" : {
            "title" : "your_title_here",
            "body" : "your_body_here"
        },
    "mutable-content": 1
    }
});

Tested both successful notifications (verifying on my device) and different error codes.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jun 28 2024, 12:37 PM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 28 2024, 12:37 PM

kamil added a child revision: D12615: [Tunnelbroker][lib] add APNs notif message type.Jun 28 2024, 12:41 PM

Harbormaster completed remote builds in B29993: Diff 41792.Jun 28 2024, 12:53 PM

kamil published this revision for review.Jun 28 2024, 1:32 PM

kamil edited the test plan for this revision. (Show Details)

bartek accepted this revision.Jul 1 2024, 9:28 AM

bartek added inline comments.

services/tunnelbroker/src/notifs/apns/mod.rs
122 ↗	(On Diff #41792)	Is this to check if the `payload` is a valid JSON? Otherwise, you could replace below `http2_client.post(...).json(&payload)` with `.body(&notif.payload)`. But you'd probably add a `Content-Type: application/json` request header manually
135–136 ↗	(On Diff #41792)	This should be possible