Page MenuHomePhabricator
Differential D12618

[keyserver] don't display the QR code if keyserver is already logged in
AcceptedPublic
Actions

Authored by varun on Fri, Jun 28, 12:53 PM.
Tags
None
Referenced Files
F2171300: D12618.diff
Tue, Jul 2, 5:40 PM
Unknown Object (File)
Sat, Jun 29, 1:48 AM
Unknown Object (File)
Sat, Jun 29, 1:48 AM
Unknown Object (File)
Sat, Jun 29, 1:45 AM
Subscribers
tomek

Details

Reviewers
ashoat
Summary

If the keyserver is logged in with the identity service, we don't need the keyserver owner to do QR code auth

Depends on D12213

Test Plan

confirmed that the QR code is not displayed if the mariadb metadata table has auth metadata

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun created this revision.Fri, Jun 28, 12:53 PM
Herald added a subscriber: tomek. · View Herald TranscriptFri, Jun 28, 12:53 PM
varun added a child revision: D12619: [keyserver] display copyable url for qr code auth.Fri, Jun 28, 12:56 PM
Harbormaster completed remote builds in B30005: Diff 41819.Fri, Jun 28, 1:10 PM
varun requested review of this revision.Fri, Jun 28, 1:10 PM
ashoat accepted this revision.Mon, Jul 1, 4:13 PM

We'll need to be thoughtful about the lifecycle of identityInfo going forward, eg. how to re-prompt for this info if necessary

This revision is now accepted and ready to land.Mon, Jul 1, 4:13 PM

Revision Contents
Changeset List

PathSize
keyserver/
src/
30 lines

Diff 41819

View Options

keyserver/src/keyserver.js

Loading...