[keyserver] don't display the QR code if keyserver is already logged in
ClosedPublic
Actions

Authored by varun on Jun 28 2024, 12:53 PM.

Details

Reviewers

ashoat

Commits

rCOMM314adf5b2f47: [keyserver] don't display the QR code if keyserver is already logged in

Summary

If the keyserver is logged in with the identity service, we don't need the keyserver owner to do QR code auth

Depends on D12213

Test Plan

confirmed that the QR code is not displayed if the mariadb metadata table has auth metadata

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Jun 28 2024, 12:53 PM

Herald added a subscriber: tomek. · View Herald TranscriptJun 28 2024, 12:53 PM

varun added a child revision: D12619: [keyserver] display copyable url for qr code auth.Jun 28 2024, 12:56 PM

Harbormaster completed remote builds in B30005: Diff 41819.Jun 28 2024, 1:10 PM

varun requested review of this revision.Jun 28 2024, 1:10 PM

We'll need to be thoughtful about the lifecycle of identityInfo going forward, eg. how to re-prompt for this info if necessary

This revision is now accepted and ready to land.Jul 1 2024, 4:13 PM

Closed by commit rCOMM314adf5b2f47: [keyserver] don't display the QR code if keyserver is already logged in (authored by varun). · Explain WhyJul 12 2024, 12:18 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM314adf5b2f47: [keyserver] don't display the QR code if keyserver is already logged in.

ashoat mentioned this in D12708: [keyserver] configure separation of primary secondary logic.Jul 12 2024, 7:21 AM

Revision Contents
Changeset List

Path

Size

keyserver/

src/

keyserver.js

30 lines

Diff 41819

View Options

keyserver/src/keyserver.js

[keyserver] don't display the QR code if keyserver is already logged inClosedPublicActions