Paths

Table of Contentst

[Tunnelbroker] implement errors from FCM service
ClosedPublic
Actions

Authored by kamil on Jul 16 2024, 8:24 AM.

Details

Reviewers

bartek
marcin

Commits

rCOMM46548e0657dd: [Tunnelbroker] implement errors from FCM service

Summary

Implementing response status described in Error codes for FCM failure conditions.

There is no error about an invalid device token, created: ENG-8824.

Depends on D12767

Test Plan

cargo check

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Jul 16 2024, 8:24 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 16 2024, 8:24 AM

kamil added a child revision: D12769: [Tunnelbroker] implement sending FCM message.Jul 16 2024, 8:24 AM

Harbormaster completed remote builds in B30363: Diff 42325.Jul 16 2024, 8:46 AM

kamil published this revision for review.Jul 16 2024, 9:42 AM

kamil edited the summary of this revision. (Show Details)

bartek accepted this revision.Jul 17 2024, 4:05 PM

This revision is now accepted and ready to land.Jul 17 2024, 4:05 PM

Closed by commit rCOMM46548e0657dd: [Tunnelbroker] implement errors from FCM service. · Explain WhyJul 19 2024, 12:05 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM46548e0657dd: [Tunnelbroker] implement errors from FCM service.

kamil mentioned this in D12935: [Tunnelbroker] send push notifs to windows devices.Aug 7 2024, 7:42 AM

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

src/

notifs/

fcm/

error.rs

2 lines

mod.rs

1 line

response.rs

44 lines

Diff 42325

View Options

services/tunnelbroker/src/notifs/fcm/error.rs

View Options

services/tunnelbroker/src/notifs/fcm/mod.rs

View Options

services/tunnelbroker/src/notifs/fcm/response.rs

[Tunnelbroker] implement errors from FCM serviceClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 42325

services/tunnelbroker/src/notifs/fcm/error.rs

services/tunnelbroker/src/notifs/fcm/mod.rs

services/tunnelbroker/src/notifs/fcm/response.rs

[Tunnelbroker] implement errors from FCM service
ClosedPublic
Actions

Revision Contents
Changeset List