Paths

Table of Contentst

-
services/tunnelbroker/src/websockets/
-
tunnelbroker/
-
src/
-
websockets/
-
session.rs

Differential D12773

[Tunnelbroker] simplify retrieving device token
ClosedPublic
Actions

Authored by kamil on Jul 16 2024, 1:54 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Apr 6, 9:08 AM

	Unknown Object (File)
	Thu, Apr 3, 6:04 PM

	Unknown Object (File)
	Mar 11 2025, 11:58 PM

	Unknown Object (File)
	Mar 11 2025, 5:41 PM

	Unknown Object (File)
	Mar 6 2025, 5:02 AM

	Unknown Object (File)
	Jan 15 2025, 11:01 AM

	Unknown Object (File)
	Jan 3 2025, 8:08 PM

	Unknown Object (File)
	Dec 29 2024, 6:09 PM

View All 55 Files

Subscribers

Details

Reviewers

bartek
marcin

Commits

rCOMM277b5d3e7ec5: [Tunnelbroker] simplify retrieving device token

Summary

Refactor to reduce code duplication and improve readability.

Depends on D12771

Test Plan

cargo build

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jul 16 2024, 1:54 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 16 2024, 1:54 AM

Harbormaster completed remote builds in B30368: Diff 42330.Jul 16 2024, 2:16 AM

kamil published this revision for review.Jul 16 2024, 2:47 AM

kamil mentioned this in D12771: [Tunnelbroker] implement sending FCM notifs by client.

bartek accepted this revision.Jul 18 2024, 7:21 AM

This revision is now accepted and ready to land.Jul 18 2024, 7:21 AM

Closed by commit rCOMM277b5d3e7ec5: [Tunnelbroker] simplify retrieving device token (authored by kamil). · Explain WhyJul 19 2024, 5:45 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM277b5d3e7ec5: [Tunnelbroker] simplify retrieving device token.

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

src/

websockets/

66 lines

Diff 42534

services/tunnelbroker/src/websockets/session.rs

	Show First 20 Lines • Show All 172 Lines • ▼ Show 20 Lines		infoValidator: tShape<ThreadJoinUpdateInfo>({
	type: tNumber(updateTypes.JOIN_THREAD),			type: tNumber(updateTypes.JOIN_THREAD),
	id: t.String,			id: t.String,
	time: t.Number,			time: t.Number,
	threadInfo: mixedRawThreadInfoValidator,			threadInfo: mixedRawThreadInfoValidator,
	rawMessageInfos: t.list(rawMessageInfoValidator),			rawMessageInfos: t.list(rawMessageInfoValidator),
	truncationStatus: messageTruncationStatusValidator,			truncationStatus: messageTruncationStatusValidator,
	rawEntryInfos: t.list(rawEntryInfoValidator),			rawEntryInfos: t.list(rawEntryInfoValidator),
	}),			}),
				getUpdatedThreadInfo: (update: ThreadJoinUpdateInfo) => update.threadInfo,
	});			});