Details

Reviewers

kamil
inka

Commits

rCOMM20323899bb24: [lib] DMOperationSpec for reaction operation

Summary

Create the spec.

https://linear.app/comm/issue/ENG-8732/create-dmoperations-for-reactions

Test Plan

Just the Flow. Further testing will be performed after it is connected with the rest of the app.

Diff Detail

Repository

rCOMM Comm

Branch

dmops

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Jul 19 2024, 12:52 PM

Herald added a subscriber: ashoat. · View Herald TranscriptJul 19 2024, 12:52 PM

Rename

Harbormaster completed remote builds in B30516: Diff 42551.Jul 19 2024, 1:09 PM

Harbormaster completed remote builds in B30518: Diff 42553.Jul 19 2024, 1:19 PM

tomek requested review of this revision.Jul 19 2024, 1:19 PM

Rename file

Harbormaster completed remote builds in B30520: Diff 42555.Jul 19 2024, 1:49 PM

On the keyserver, when reactionMessageCreationResponder is called, it calls createMessages which in turn calls updateRepliesCount. Do we need to do something like this for DMs?

I wonder if we should have a separate task for updating the replies count. I don't think I contemplated it in sendTextMessageSpec

In D12806#363499, @ashoat wrote:

I wonder if we should have a separate task for updating the replies count. I don't think I contemplated it in sendTextMessageSpec

Created https://linear.app/comm/issue/ENG-8892/handle-replies-count-as-a-part-of-dmoperationspecs to track