Page MenuHomePhabricator
Differential D12806

[lib] DMOperationSpec for reaction operation
ClosedPublic
Actions

Authored by tomek on Jul 19 2024, 12:52 PM.
Tags
None
Referenced Files
F3367799: D12806.diff
Mon, Nov 25, 4:26 PM
Unknown Object (File)
Mon, Nov 11, 1:42 PM
Unknown Object (File)
Mon, Nov 11, 11:27 AM
Unknown Object (File)
Mon, Nov 11, 9:28 AM
Unknown Object (File)
Mon, Nov 11, 7:44 AM
Unknown Object (File)
Mon, Nov 11, 6:39 AM
Unknown Object (File)
Mon, Nov 11, 4:56 AM
Unknown Object (File)
Sun, Nov 10, 10:07 PM
View All 85 Files
Subscribers
ashoat

Details

Reviewers
kamil
inka
Commits
rCOMM20323899bb24: [lib] DMOperationSpec for reaction operation
Summary

Create the spec.

https://linear.app/comm/issue/ENG-8732/create-dmoperations-for-reactions

Test Plan

Just the Flow. Further testing will be performed after it is connected with the rest of the app.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.Jul 19 2024, 12:52 PM
Herald added a subscriber: ashoat. · View Herald TranscriptJul 19 2024, 12:52 PM
tomek updated this revision to Diff 42553.Jul 19 2024, 12:59 PM
tomek added a child revision: D12807: [lib] DMOperationSpec for edit operation.

Rename

Harbormaster completed remote builds in B30516: Diff 42551.Jul 19 2024, 1:09 PM
Harbormaster completed remote builds in B30518: Diff 42553.Jul 19 2024, 1:19 PM
tomek requested review of this revision.Jul 19 2024, 1:19 PM
tomek updated this revision to Diff 42555.Jul 19 2024, 1:33 PM

Rename file

Harbormaster completed remote builds in B30520: Diff 42555.Jul 19 2024, 1:49 PM
inka added a comment.Jul 22 2024, 6:43 AM

On the keyserver, when reactionMessageCreationResponder is called, it calls createMessages which in turn calls updateRepliesCount. Do we need to do something like this for DMs?

ashoat added a comment.Jul 22 2024, 10:56 AM

I wonder if we should have a separate task for updating the replies count. I don't think I contemplated it in sendTextMessageSpec

tomek added a comment.Jul 23 2024, 7:00 AM
In D12806#363499, @ashoat wrote:

I wonder if we should have a separate task for updating the replies count. I don't think I contemplated it in sendTextMessageSpec

Created https://linear.app/comm/issue/ENG-8892/handle-replies-count-as-a-part-of-dmoperationspecs to track

tomek updated this revision to Diff 42699.Jul 23 2024, 7:28 AM

Add to specs

Harbormaster completed remote builds in B30612: Diff 42699.Jul 23 2024, 7:44 AM
inka accepted this revision.Jul 25 2024, 1:03 AM
This revision is now accepted and ready to land.Jul 25 2024, 1:03 AM
tomek updated this revision to Diff 42817.Jul 26 2024, 4:25 AM

Rename

Harbormaster completed remote builds in B30700: Diff 42817.Jul 26 2024, 4:42 AM
Closed by commit rCOMM20323899bb24: [lib] DMOperationSpec for reaction operation (authored by tomek). · Explain WhyJul 26 2024, 5:22 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM20323899bb24: [lib] DMOperationSpec for reaction operation.

Revision Contents
Changeset List

PathSize
lib/
shared/
dm-ops/
2 lines
54 lines
types/
27 lines

Diff 42699

View Options

lib/shared/dm-ops/dm-op-specs.js

Loading...
View Options

lib/shared/dm-ops/send-reaction-message-spec.js

Loading...
View Options

lib/types/dm-ops.js

Loading...