[lib][native][web] Introduce threadTypeIsSidebar
ClosedPublic
Actions

Authored by ashoat on Jul 22 2024, 8:05 AM.

Details

Reviewers

tomek
kamil
marcin

Commits

rCOMMde39c3067550: [lib][native][web] Introduce threadTypeIsSidebar

Summary

In this diff we replace threadTypes.SIDEBAR checks with threadTypeIsSidebar, a new utility function that also checks threadTypes.THICK_SIDEBAR. This allows our business logic to treat the two in the same way.

Test Plan

I followed the test plan described in this Linear comment, specifically for sidebar creation

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Jul 22 2024, 8:05 AM

Harbormaster completed remote builds in B30565: Diff 42616.Jul 22 2024, 8:21 AM

ashoat requested review of this revision.Jul 22 2024, 8:21 AM

tomek accepted this revision.Jul 23 2024, 1:12 AM

tomek added inline comments.

lib/types/thread-types-enum.js
168 ↗	(On Diff #42616)	It might be more convenient to accept an optional `threadType`. Then, in some places, we could simplify the usages by passing `threadInfo?.threadType` as a parameter.

This revision is now accepted and ready to land.Jul 23 2024, 1:12 AM

ashoat added inline comments.Jul 23 2024, 4:36 AM

lib/types/thread-types-enum.js
168 ↗	(On Diff #42616)	That's a fair point, but it's a change that makes sense to make for all of the `threadTypeIs*` functions above, and I don't have time to make it this morning