Page MenuHomePhabricator

[lib] DMOperationSpec for remove members operation
ClosedPublic

Authored by tomek on Jul 24 2024, 10:43 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 6:25 PM
Unknown Object (File)
Fri, Nov 22, 2:20 PM
Unknown Object (File)
Fri, Nov 22, 9:13 AM
Unknown Object (File)
Thu, Nov 21, 1:50 AM
Unknown Object (File)
Mon, Nov 11, 12:50 PM
Unknown Object (File)
Mon, Nov 11, 9:12 AM
Unknown Object (File)
Mon, Nov 11, 6:24 AM
Unknown Object (File)
Mon, Nov 11, 5:37 AM
Subscribers

Details

Summary
Test Plan

Just the Flow. Further testing will be performed after it is connected with the rest of the app.

Diff Detail

Repository
rCOMM Comm
Branch
dmops
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 24 2024, 11:00 AM
Harbormaster failed remote builds in B30648: Diff 42744!
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 25 2024, 9:06 AM
Harbormaster failed remote builds in B30671: Diff 42775!
tomek requested review of this revision.Jul 26 2024, 3:26 AM
lib/shared/dm-ops/remove-members-spec.js
48–53 ↗(On Diff #42822)

Is this correct for sidebars?

67 ↗(On Diff #42822)

Should we update the unread status?
Should we maybe think of doing that in the reducer instead of creating an action in all specs?

tomek marked an inline comment as done.

Correctly handle sidebars

lib/shared/dm-ops/remove-members-spec.js
67 ↗(On Diff #42822)

Hmmm... I guess we could update the unread status every time a new message appears in the store.

inka added inline comments.
lib/shared/dm-ops/remove-members-spec.js
67 ↗(On Diff #42822)

This would also make it easier to only update the status when a message with a bigger timestamp than all previous messages appears, if we decided we wanted to do that.

This revision is now accepted and ready to land.Jul 31 2024, 2:11 AM
lib/shared/dm-ops/remove-members-spec.js
67 ↗(On Diff #42822)

It seems like updating the read status and replies count is really similar. But I'm not sure how to do it well. Going to search for a good solution.