Page MenuHomePhabricator
Differential D12872

[lib] DMOperationSpec for remove members operation
ClosedPublic
Actions

Authored by tomek on Jul 24 2024, 10:43 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 24, 5:49 PM
Unknown Object (File)
Sun, Mar 23, 12:58 PM
Unknown Object (File)
Wed, Mar 12, 4:23 AM
Unknown Object (File)
Tue, Mar 11, 11:55 PM
Unknown Object (File)
Wed, Mar 5, 10:07 PM
Unknown Object (File)
Wed, Mar 5, 4:48 AM
Unknown Object (File)
Sun, Mar 2, 10:47 PM
Unknown Object (File)
Feb 18 2025, 3:12 AM
View All Files
Subscribers
ashoat

Details

Reviewers
kamil
inka
Commits
rCOMMfc12922a4b56: [lib] DMOperationSpec for remove members operation
Summary

Create the spec.

https://linear.app/comm/issue/ENG-8738/create-dmoperations-for-removemembersmessageinfo

Depends on D12871

Test Plan

Just the Flow. Further testing will be performed after it is connected with the rest of the app.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.Jul 24 2024, 10:43 AM
Herald added a subscriber: ashoat. · View Herald TranscriptJul 24 2024, 10:43 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 24 2024, 11:00 AM
Harbormaster failed remote builds in B30648: Diff 42744!
tomek added a child revision: D12881: [lib] DMOperationSpec for change thread settings operation.Jul 25 2024, 8:47 AM
tomek updated this revision to Diff 42775.Jul 25 2024, 8:58 AM

Rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 25 2024, 9:06 AM
Harbormaster failed remote builds in B30671: Diff 42775!
tomek updated this revision to Diff 42807.Jul 26 2024, 3:05 AM

Rebase

Harbormaster completed remote builds in B30691: Diff 42807.Jul 26 2024, 3:26 AM
tomek requested review of this revision.Jul 26 2024, 3:26 AM
tomek updated this revision to Diff 42822.Jul 26 2024, 4:36 AM

Rename

Harbormaster completed remote builds in B30705: Diff 42822.Jul 26 2024, 5:04 AM
inka added inline comments.Jul 26 2024, 5:31 AM
lib/shared/dm-ops/remove-members-spec.js
48–53 ↗(On Diff #42822)

Is this correct for sidebars?

67 ↗(On Diff #42822)

Should we update the unread status?
Should we maybe think of doing that in the reducer instead of creating an action in all specs?

tomek updated this revision to Diff 42899.Jul 29 2024, 6:46 AM
tomek marked an inline comment as done.

Correctly handle sidebars

Harbormaster completed remote builds in B30757: Diff 42899.Jul 29 2024, 7:02 AM
tomek added inline comments.Jul 29 2024, 7:14 AM
lib/shared/dm-ops/remove-members-spec.js
67 ↗(On Diff #42822)

Hmmm... I guess we could update the unread status every time a new message appears in the store.

inka accepted this revision.Jul 31 2024, 2:11 AM
inka added inline comments.
lib/shared/dm-ops/remove-members-spec.js
67 ↗(On Diff #42822)

This would also make it easier to only update the status when a message with a bigger timestamp than all previous messages appears, if we decided we wanted to do that.

This revision is now accepted and ready to land.Jul 31 2024, 2:11 AM
tomek added inline comments.Aug 1 2024, 5:17 AM
lib/shared/dm-ops/remove-members-spec.js
67 ↗(On Diff #42822)

It seems like updating the read status and replies count is really similar. But I'm not sure how to do it well. Going to search for a good solution.

Closed by commit rCOMMfc12922a4b56: [lib] DMOperationSpec for remove members operation (authored by tomek). · Explain WhyAug 2 2024, 8:38 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMMfc12922a4b56: [lib] DMOperationSpec for remove members operation.

Revision Contents
Changeset List

PathSize
lib/
shared/
dm-ops/
2 lines
75 lines
types/
23 lines

Diff 42807

View Options

lib/shared/dm-ops/dm-op-specs.js

Show First 20 Lines • Show All 93 Lines • ▼ Show 20 Lines
import { import {
fullStateSyncActionType, fullStateSyncActionType,
incrementalStateSyncActionType, incrementalStateSyncActionType,
} from '../types/socket-types.js'; } from '../types/socket-types.js';
import { threadPermissions } from '../types/thread-permission-types.js'; import { threadPermissions } from '../types/thread-permission-types.js';
import type { import type {
LegacyRawThreadInfo, LegacyRawThreadInfo,
MinimallyEncodedRawThreadInfos, MinimallyEncodedRawThreadInfos,
RawThreadInfos, MixedRawThreadInfos,
} from '../types/thread-types.js'; } from '../types/thread-types.js';
import { import {
type ClientUpdateInfo, type ClientUpdateInfo,
processUpdatesActionType, processUpdatesActionType,
} from '../types/update-types.js'; } from '../types/update-types.js';
import { translateClientDBThreadMessageInfos } from '../utils/message-ops-utils.js'; import { translateClientDBThreadMessageInfos } from '../utils/message-ops-utils.js';
const _mapValuesWithKeys = _mapValues.convert({ cap: false }); const _mapValuesWithKeys = _mapValues.convert({ cap: false });
Show All 35 Lines
type FreshMessageStoreResult = { type FreshMessageStoreResult = {
+messageStoreOperations: $ReadOnlyArray<MessageStoreOperation>, +messageStoreOperations: $ReadOnlyArray<MessageStoreOperation>,
+messageStore: MessageStore, +messageStore: MessageStore,
}; };
function freshMessageStore( function freshMessageStore(
messageInfos: $ReadOnlyArray<RawMessageInfo>, messageInfos: $ReadOnlyArray<RawMessageInfo>,
truncationStatus: { [threadID: string]: MessageTruncationStatus }, truncationStatus: { [threadID: string]: MessageTruncationStatus },
currentAsOf: { +[keyserverID: string]: number }, currentAsOf: { +[keyserverID: string]: number },
threadInfos: RawThreadInfos, threadInfos: MixedRawThreadInfos,
): FreshMessageStoreResult { ): FreshMessageStoreResult {
const unshimmed = unshimMessageInfos(messageInfos); const unshimmed = unshimMessageInfos(messageInfos);
const orderedMessageInfos = sortMessageInfoList(unshimmed); const orderedMessageInfos = sortMessageInfoList(unshimmed);
const messages = _keyBy(messageID)(orderedMessageInfos); const messages = _keyBy(messageID)(orderedMessageInfos);
const messageStoreReplaceOperations = orderedMessageInfos.map( const messageStoreReplaceOperations = orderedMessageInfos.map(
messageInfo => ({ messageInfo => ({
type: 'replace', type: 'replace',
▲ Show 20 Lines • Show All 1,511 Lines • Show Last 20 Lines
View Options

lib/shared/dm-ops/remove-members-spec.js

Show First 20 Lines • Show All 93 Lines • ▼ Show 20 Lines
import { import {
fullStateSyncActionType, fullStateSyncActionType,
incrementalStateSyncActionType, incrementalStateSyncActionType,
} from '../types/socket-types.js'; } from '../types/socket-types.js';
import { threadPermissions } from '../types/thread-permission-types.js'; import { threadPermissions } from '../types/thread-permission-types.js';
import type { import type {
LegacyRawThreadInfo, LegacyRawThreadInfo,
MinimallyEncodedRawThreadInfos, MinimallyEncodedRawThreadInfos,
RawThreadInfos, MixedRawThreadInfos,
} from '../types/thread-types.js'; } from '../types/thread-types.js';
import { import {
type ClientUpdateInfo, type ClientUpdateInfo,
processUpdatesActionType, processUpdatesActionType,
} from '../types/update-types.js'; } from '../types/update-types.js';
import { translateClientDBThreadMessageInfos } from '../utils/message-ops-utils.js'; import { translateClientDBThreadMessageInfos } from '../utils/message-ops-utils.js';
const _mapValuesWithKeys = _mapValues.convert({ cap: false }); const _mapValuesWithKeys = _mapValues.convert({ cap: false });
Show All 35 Lines
type FreshMessageStoreResult = { type FreshMessageStoreResult = {
+messageStoreOperations: $ReadOnlyArray<MessageStoreOperation>, +messageStoreOperations: $ReadOnlyArray<MessageStoreOperation>,
+messageStore: MessageStore, +messageStore: MessageStore,
}; };
function freshMessageStore( function freshMessageStore(
messageInfos: $ReadOnlyArray<RawMessageInfo>, messageInfos: $ReadOnlyArray<RawMessageInfo>,
truncationStatus: { [threadID: string]: MessageTruncationStatus }, truncationStatus: { [threadID: string]: MessageTruncationStatus },
currentAsOf: { +[keyserverID: string]: number }, currentAsOf: { +[keyserverID: string]: number },
threadInfos: RawThreadInfos, threadInfos: MixedRawThreadInfos,
): FreshMessageStoreResult { ): FreshMessageStoreResult {
const unshimmed = unshimMessageInfos(messageInfos); const unshimmed = unshimMessageInfos(messageInfos);
const orderedMessageInfos = sortMessageInfoList(unshimmed); const orderedMessageInfos = sortMessageInfoList(unshimmed);
const messages = _keyBy(messageID)(orderedMessageInfos); const messages = _keyBy(messageID)(orderedMessageInfos);
const messageStoreReplaceOperations = orderedMessageInfos.map( const messageStoreReplaceOperations = orderedMessageInfos.map(
messageInfo => ({ messageInfo => ({
type: 'replace', type: 'replace',
▲ Show 20 Lines • Show All 1,511 Lines • Show Last 20 Lines
View Options

lib/types/dm-ops.js

Show First 20 Lines • Show All 93 Lines • ▼ Show 20 Lines
import { import {
fullStateSyncActionType, fullStateSyncActionType,
incrementalStateSyncActionType, incrementalStateSyncActionType,
} from '../types/socket-types.js'; } from '../types/socket-types.js';
import { threadPermissions } from '../types/thread-permission-types.js'; import { threadPermissions } from '../types/thread-permission-types.js';
import type { import type {
LegacyRawThreadInfo, LegacyRawThreadInfo,
MinimallyEncodedRawThreadInfos, MinimallyEncodedRawThreadInfos,
RawThreadInfos, MixedRawThreadInfos,
} from '../types/thread-types.js'; } from '../types/thread-types.js';
import { import {
type ClientUpdateInfo, type ClientUpdateInfo,
processUpdatesActionType, processUpdatesActionType,
} from '../types/update-types.js'; } from '../types/update-types.js';
import { translateClientDBThreadMessageInfos } from '../utils/message-ops-utils.js'; import { translateClientDBThreadMessageInfos } from '../utils/message-ops-utils.js';
const _mapValuesWithKeys = _mapValues.convert({ cap: false }); const _mapValuesWithKeys = _mapValues.convert({ cap: false });
Show All 35 Lines
type FreshMessageStoreResult = { type FreshMessageStoreResult = {
+messageStoreOperations: $ReadOnlyArray<MessageStoreOperation>, +messageStoreOperations: $ReadOnlyArray<MessageStoreOperation>,
+messageStore: MessageStore, +messageStore: MessageStore,
}; };
function freshMessageStore( function freshMessageStore(
messageInfos: $ReadOnlyArray<RawMessageInfo>, messageInfos: $ReadOnlyArray<RawMessageInfo>,
truncationStatus: { [threadID: string]: MessageTruncationStatus }, truncationStatus: { [threadID: string]: MessageTruncationStatus },
currentAsOf: { +[keyserverID: string]: number }, currentAsOf: { +[keyserverID: string]: number },
threadInfos: RawThreadInfos, threadInfos: MixedRawThreadInfos,
): FreshMessageStoreResult { ): FreshMessageStoreResult {
const unshimmed = unshimMessageInfos(messageInfos); const unshimmed = unshimMessageInfos(messageInfos);
const orderedMessageInfos = sortMessageInfoList(unshimmed); const orderedMessageInfos = sortMessageInfoList(unshimmed);
const messages = _keyBy(messageID)(orderedMessageInfos); const messages = _keyBy(messageID)(orderedMessageInfos);
const messageStoreReplaceOperations = orderedMessageInfos.map( const messageStoreReplaceOperations = orderedMessageInfos.map(
messageInfo => ({ messageInfo => ({
type: 'replace', type: 'replace',
▲ Show 20 Lines • Show All 1,511 Lines • Show Last 20 Lines