[identity] Rewrite GetDeviceLists RPC to use batch functions
ClosedPublic
Actions

Authored by bartek on Jul 26 2024, 2:57 AM.

Details

Reviewers

varun
will
kamil

Commits

rCOMMc54e535c5b84: [identity] Rewrite GetDeviceLists RPC to use batch functions

Summary

Final part of GetDeviceListsForUsers RPC rewrite. Details in ENG-8843.

Replaced old implementation with a new one that uses batch functions introduced in D12888 and D12889.

Depends on D12889

Test Plan

Detailed test plan in ENG-8843.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Jul 26 2024, 2:57 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 26 2024, 2:57 AM

Harbormaster completed remote builds in B30689: Diff 42805.Jul 26 2024, 3:15 AM

bartek published this revision for review.Jul 26 2024, 3:46 AM

kamil resigned from this revision.Jul 29 2024, 2:23 AM

varun accepted this revision.Jul 29 2024, 10:16 PM

This revision is now accepted and ready to land.Jul 29 2024, 10:16 PM

Closed by commit rCOMMc54e535c5b84: [identity] Rewrite GetDeviceLists RPC to use batch functions (authored by bartek). · Explain WhyJul 30 2024, 6:05 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMc54e535c5b84: [identity] Rewrite GetDeviceLists RPC to use batch functions.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

grpc_services/

authenticated.rs

127 lines

Diff 42805

View Options

services/identity/src/grpc_services/authenticated.rs

[identity] Rewrite GetDeviceLists RPC to use batch functionsClosedPublicActions