[Tunnelbroker] invalidate bad Web Push tokens
ClosedPublic
Actions

Authored by kamil on Jul 30 2024, 6:06 AM.

Details

Reviewers

bartek
marcin

Commits

rCOMM2960f788547e: [Tunnelbroker] invalidate bad Web Push tokens

Summary

ENG-8498.

Based on keyserver error codes.
Here is library mapping of status to errors used in this diff.

Depends on D12911

Test Plan

Manually malform device token for web device in DDB (url in JSON), try sending notif to this device and verify that flag was flipped and the message was sent to the device (both online and offline device).

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jul 30 2024, 6:06 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 30 2024, 6:06 AM

kamil published this revision for review.Jul 30 2024, 6:18 AM

Harbormaster completed remote builds in B30816: Diff 42969.Jul 30 2024, 7:15 AM

bartek accepted this revision.Jul 30 2024, 7:53 AM

bartek added inline comments.

services/tunnelbroker/src/websockets/session.rs
519–537 ↗	(On Diff #42969)	maybe doing sth like use notifs::web_push::error::Error as NotifError; use web_push::WebPushError; locally here in this function, it could make these lines shorter