[terraform] Add Backup to ECS Service Connect
ClosedPublic
Actions

Authored by bartek on Aug 5 2024, 4:56 AM.

Details

Reviewers

will
varun
kamil

Commits

rCOMM61dc78e5062b: [terraform] Add Backup to ECS Service Connect

Summary

Needed to make Backup service discoverable in ECS Service Connect, to let Identity reach it when deleting user data.

Depends on D12972

Test Plan

terraform plan + tested on staging

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Aug 5 2024, 4:56 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 5 2024, 4:56 AM

bartek published this revision for review.Aug 5 2024, 5:09 AM

Looks good but I am not experienced enough with terraform - leaving this to @will's expertise

Looks good to me!

This revision is now accepted and ready to land.Aug 5 2024, 6:19 AM

This revision was landed with ongoing or failed builds.Aug 5 2024, 6:28 AM

Closed by commit rCOMM61dc78e5062b: [terraform] Add Backup to ECS Service Connect (authored by bartek). · Explain Why

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM61dc78e5062b: [terraform] Add Backup to ECS Service Connect.

Harbormaster failed remote builds in B30911: Diff 43091!Aug 5 2024, 6:45 AM

Revision Contents
Changeset List

Path

Size

services/

terraform/

remote/

service_backup.tf

25 lines

service_identity.tf

4 lines

Diff 43127

View Options

services/terraform/remote/service_backup.tf

This file was added.

				// @flow

				import type {
				StackNavigationEventMap,
				StackNavigationState,
				StackOptions,
				} from '@react-navigation/core';
				import * as React from 'react';
				import { Text } from 'react-native';

				import { type QRAuthNavigationProp } from './qr-auth-navigator.react.js';
				import RegistrationButtonContainer from '../../account/registration/registration-button-container.react.js';
				import RegistrationContainer from '../../account/registration/registration-container.react.js';
				import RegistrationContentContainer from '../../account/registration/registration-content-container.react.js';
				import PrimaryButton from '../../components/primary-button.react.js';
				import type { RootNavigationProp } from '../../navigation/root-navigator.react.js';
				import {
				type NavigationRoute,
				type ScreenParamList,
				} from '../../navigation/route-names.js';
				import { useStyles } from '../../themes/colors.js';

				type Props = {
				+navigation: QRAuthNavigationProp<'QRAuthNotPrimaryDevice'>,
				+route: NavigationRoute<'QRAuthNotPrimaryDevice'>,
				};

				function QRAuthNotPrimaryDevice(prop: Props): React.Node {
				const { navigation } = prop;
				const styles = useStyles(unboundStyles);

				const onPressGoBack = React.useCallback(() => {
				navigation
				.getParent<
				ScreenParamList,
				'LinkedDevicesBottomSheet',
				StackNavigationState,
				StackOptions,
				StackNavigationEventMap,
				RootNavigationProp<'LinkedDevicesBottomSheet'>,
				>()
				?.goBack();
				}, [navigation]);

				return (
				<RegistrationContainer>
				<RegistrationContentContainer>
				<Text style={styles.header}>Device not primary</Text>
				<Text style={styles.body}>
				This mobile device is not your primary device, and cannot be used to
				authorize new devices. Please try your other mobile device(s).
				</Text>
				</RegistrationContentContainer>
				<RegistrationButtonContainer>
				<PrimaryButton
				onPress={onPressGoBack}
				label="Go back"
				variant="enabled"
				/>
				</RegistrationButtonContainer>
				</RegistrationContainer>
				);
				}

				const unboundStyles = {
				header: {
				fontSize: 24,
				color: 'panelForegroundLabel',
				paddingBottom: 16,
				},
				body: {
				fontFamily: 'Arial',
				fontSize: 15,
				lineHeight: 20,
				color: 'panelForegroundSecondaryLabel',
				paddingBottom: 16,
				},
				};

				export default QRAuthNotPrimaryDevice;