Page MenuHomePhabricator
Differential D13141

[native] Expose messages fetching function through JSI
ClosedPublic
Actions

Authored by tomek on Aug 22 2024, 10:40 AM.
Tags
None
Referenced Files
F2842314: D13141.diff
Sun, Sep 29, 1:17 PM
Unknown Object (File)
Wed, Sep 25, 3:44 PM
Unknown Object (File)
Wed, Sep 25, 3:44 PM
Unknown Object (File)
Wed, Sep 25, 3:44 PM
Unknown Object (File)
Wed, Sep 25, 3:44 PM
Unknown Object (File)
Wed, Sep 25, 3:44 PM
Unknown Object (File)
Tue, Sep 24, 11:27 PM
Unknown Object (File)
Sat, Sep 14, 10:32 AM
View All 41 Files
Subscribers
ashoat

Details

Reviewers
kamil
inka
Commits
rCOMM3a23e30a4fc0: [native] Expose messages fetching function through JSI
Summary

Expose the function through JSI so that it can be used on native clients.

https://linear.app/comm/issue/ENG-8701/create-c-functions-that-fetch-a-subset-of-messages

Depends on D13140

Test Plan

Tested this later in the stack by creating a thick thread on native, with 100 messages, closing and reopening the app, and scrolling up - verified that all the messages were eventually shown.

Diff Detail

Repository
rCOMM Comm
Branch
messages-pruning
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.Aug 22 2024, 10:40 AM
Herald added a subscriber: ashoat. · View Herald TranscriptAug 22 2024, 10:40 AM
tomek added a child revision: D13142: [web] Expose messages fetching function through the worker and sqlite-api.Aug 22 2024, 10:48 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Aug 22 2024, 11:04 AM
Harbormaster failed remote builds in B31221: Diff 43592!
tomek updated this revision to Diff 43598.Aug 23 2024, 3:54 AM

Fix compilation error

Harbormaster completed remote builds in B31225: Diff 43598.Aug 23 2024, 4:11 AM
tomek requested review of this revision.Aug 23 2024, 4:11 AM
kamil accepted this revision.Aug 26 2024, 2:49 AM

Please update the test plan, accepting it because it looks like it was tested later in the stack

This revision is now accepted and ready to land.Aug 26 2024, 2:49 AM
tomek edited the test plan for this revision. (Show Details)Aug 27 2024, 4:48 AM
Closed by commit rCOMM3a23e30a4fc0: [native] Expose messages fetching function through JSI (authored by tomek). · Explain WhyAug 27 2024, 8:02 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM3a23e30a4fc0: [native] Expose messages fetching function through JSI.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
5 lines
42 lines
_generated/
schema/
5 lines

Diff 43592

View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI.h

Loading...
View Options

native/schema/CommCoreModuleSchema.js

Loading...