Page MenuHomePhabricator
Differential D13280

[lib] Make media metadata upload to keyserver optional
ClosedPublic
Actions

Authored by bartek on Sep 11 2024, 1:21 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 12, 9:32 AM
Unknown Object (File)
Tue, Nov 12, 9:32 AM
Unknown Object (File)
Tue, Nov 12, 3:37 AM
Unknown Object (File)
Tue, Nov 12, 1:32 AM
Unknown Object (File)
Oct 23 2024, 9:06 PM
Unknown Object (File)
Oct 12 2024, 1:05 AM
Unknown Object (File)
Oct 12 2024, 1:05 AM
Unknown Object (File)
Oct 12 2024, 1:05 AM
View All 30 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
tomek
Commits
rCOMMd641b6e240a4: [lib] Make media metadata upload to keyserver optional
Summary

Part of ENG-8708.

Updated useBlobServiceUpload() to perform keyserver metadata upload only when keyserverOrThreadID is present.

Test Plan

Tested together with other diffs in the stack

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Sep 11 2024, 1:21 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 11 2024, 1:21 AM
bartek added a child revision: D13281: [web][native] Enable blob uploads for thick threads in input-state-container.Sep 11 2024, 1:23 AM
Harbormaster completed remote builds in B31518: Diff 44022.Sep 11 2024, 1:38 AM
bartek added a child revision: D13286: [web] Support setting image avatars for thick threads.Sep 11 2024, 1:41 AM
bartek published this revision for review.Sep 11 2024, 2:01 AM
bartek added inline comments.
lib/actions/upload-actions.js
245–256

The logic here matches what we do on keyserver: here, here and here

bartek added a reviewer: tomek.Sep 11 2024, 2:09 AM
tomek accepted this revision.Sep 11 2024, 2:37 AM
This revision is now accepted and ready to land.Sep 11 2024, 2:37 AM
bartek mentioned this in D13294: [native] Update avatar hooks to support skipping keyserver upload.Sep 11 2024, 10:57 AM
kamil accepted this revision.Sep 12 2024, 3:17 AM
Closed by commit rCOMMd641b6e240a4: [lib] Make media metadata upload to keyserver optional (authored by bartek). · Explain WhySep 13 2024, 5:45 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMd641b6e240a4: [lib] Make media metadata upload to keyserver optional.
bartek mentioned this in rCOMMdf0080acb36e: [native] Update avatar hooks to support skipping keyserver upload.

Revision Contents
Changeset List

PathSize
lib/
actions/
44 lines

Diff 44022

View Options

lib/actions/upload-actions.js

Loading...