Page MenuHomePhabricator

[web] Avoid keyserver call when deleting media for DMs
ClosedPublic

Authored by bartek on Sep 11 2024, 1:27 AM.
Tags
None
Referenced Files
F3234095: D13282.diff
Tue, Nov 12, 5:15 PM
F3230729: D13282.id.diff
Tue, Nov 12, 8:51 AM
F3230498: D13282.id44162.diff
Tue, Nov 12, 7:57 AM
F3228764: D13282.id44024.diff
Tue, Nov 12, 3:30 AM
F3228137: D13282.diff
Tue, Nov 12, 1:09 AM
Unknown Object (File)
Mon, Nov 4, 3:52 PM
Unknown Object (File)
Oct 12 2024, 1:05 AM
Unknown Object (File)
Oct 12 2024, 1:05 AM
Subscribers

Details

Summary

On web, we pre-upload media as soon as it is selected, before actually sending the message. When user decides not to send the image (clicks the cross button in the corner),
the uploaded media gets deleted. This results in keyserver call: this.props.deleteUpload(). For DMs, we want to avoid such call.

Needed to update some code to pass the whole threadInfo of active chat, instead of only threadID.

Depends on D13281

Test Plan
  • Verified that behavior for keyserver media hasn't been changed and the endpoint is still called
  • TBD for DMs

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable