Page MenuHomePhabricator

[web] Skip `loop` property when dispatching updateMultimediaMessage
ClosedPublic

Authored by bartek on Sep 23 2024, 2:04 AM.
Tags
None
Referenced Files
F3345411: D13419.diff
Fri, Nov 22, 5:57 AM
Unknown Object (File)
Fri, Nov 8, 2:08 AM
Unknown Object (File)
Fri, Nov 8, 2:08 AM
Unknown Object (File)
Fri, Nov 8, 2:08 AM
Unknown Object (File)
Fri, Nov 1, 5:35 AM
Unknown Object (File)
Fri, Oct 25, 2:37 AM
Unknown Object (File)
Oct 21 2024, 5:41 AM
Unknown Object (File)
Oct 18 2024, 2:34 PM
Subscribers

Details

Summary

Resolves 1 from ENG-9345.
We shouldn't add loop property when updating photo multimedia message. Otherwise, the DM Ops validator would reject such message.

Test Plan

Quickly-sent a DM and made sure the payload doesn't contain the loop property the DM op is processed successfully on recipient side.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek held this revision as a draft.
This revision is now accepted and ready to land.Sep 23 2024, 2:37 AM

Is there a risk here that the loop property isn't being populated correctly where it should be? I believe this is meant to be used for video, where we want the video to autoplay, and then loop back to the start when it finishes and continue playing. Not sure it works correctly, but ideally we can avoid breaking it more

Is there a risk here that the loop property isn't being populated correctly where it should be? I believe this is meant to be used for video, where we want the video to autoplay, and then loop back to the start when it finishes and continue playing. Not sure it works correctly, but ideally we can avoid breaking it more

Yes it's used only for videos. I made sure that here in web input-state-container it's only used for upload calls and not for displaying videos. Since we're not uploading videos from web, it won't break anything.