[web] Skip `loop` property when dispatching updateMultimediaMessage
ClosedPublic
Actions

Authored by bartek on Mon, Sep 23, 2:04 AM.

Details

Reviewers

kamil
tomek

Commits

rCOMMe51fd3572e21: [web] Skip `loop` property when dispatching updateMultimediaMessage

Summary

Resolves 1 from ENG-9345.
We shouldn't add loop property when updating photo multimedia message. Otherwise, the DM Ops validator would reject such message.

Test Plan

Quickly-sent a DM and made sure the payload doesn't contain the loop property the DM op is processed successfully on recipient side.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Mon, Sep 23, 2:04 AM

bartek held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptMon, Sep 23, 2:04 AM

bartek published this revision for review.Mon, Sep 23, 2:17 AM

bartek added a child revision: D13420: [web] Fix multimedia sending conditions for thick threads.

Harbormaster completed remote builds in B31759: Diff 44405.Mon, Sep 23, 2:21 AM

kamil accepted this revision.Mon, Sep 23, 2:37 AM

This revision is now accepted and ready to land.Mon, Sep 23, 2:37 AM

Is there a risk here that the loop property isn't being populated correctly where it should be? I believe this is meant to be used for video, where we want the video to autoplay, and then loop back to the start when it finishes and continue playing. Not sure it works correctly, but ideally we can avoid breaking it more

In D13419#377701, @ashoat wrote:

Is there a risk here that the loop property isn't being populated correctly where it should be? I believe this is meant to be used for video, where we want the video to autoplay, and then loop back to the start when it finishes and continue playing. Not sure it works correctly, but ideally we can avoid breaking it more

Yes it's used only for videos. I made sure that here in web input-state-container it's only used for upload calls and not for displaying videos. Since we're not uploading videos from web, it won't break anything.

Closed by commit rCOMMe51fd3572e21: [web] Skip `loop` property when dispatching updateMultimediaMessage (authored by bartek). · Explain WhyMon, Sep 23, 7:25 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMe51fd3572e21: [web] Skip `loop` property when dispatching updateMultimediaMessage.