Page MenuHomePhabricator
Differential D13468

Add AES cryptography to EncryptedNotifUtilsAPI
ClosedPublic
Actions

Authored by marcin on Wed, Sep 25, 11:11 AM.
Tags
None
Referenced Files
F2838986: D13468.diff
Sun, Sep 29, 12:23 AM
Unknown Object (File)
Wed, Sep 25, 12:22 PM
Unknown Object (File)
Wed, Sep 25, 12:21 PM
Unknown Object (File)
Wed, Sep 25, 12:04 PM
Subscribers
ashoat

Details

Reviewers
kamil
tomek
bartek
Commits
rCOMM0a028741d881: Add AES cryptography to EncryptedNotifUtilsAPI
Summary

This differential adds AES cryptography to EncryptedNotifUtilsAPI

Test Plan

Tested in the final diff

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Wed, Sep 25, 11:11 AM
Herald added a subscriber: ashoat. · View Herald TranscriptWed, Sep 25, 11:11 AM
marcin added a parent revision: D13467: Enable AES encryption with custom IV on web/keyserver.Wed, Sep 25, 11:12 AM
marcin added a child revision: D13469: Create large notifications in thick threads.
Harbormaster completed remote builds in B31851: Diff 44561.Wed, Sep 25, 11:28 AM
marcin requested review of this revision.Wed, Sep 25, 11:28 AM
marcin removed a parent revision: D13467: Enable AES encryption with custom IV on web/keyserver.Thu, Sep 26, 1:30 AM
marcin updated this revision to Diff 44590.Thu, Sep 26, 1:31 AM

Update to simpler approach

Harbormaster completed remote builds in B31872: Diff 44590.Thu, Sep 26, 1:48 AM
bartek accepted this revision.Thu, Sep 26, 2:14 AM
bartek added inline comments.
web/push-notif/encrypted-notif-utils-api.js
50 ↗(On Diff #44590)

TIL: we have Webpack polyfill for Buffer on web.
I was sure Buffer is a Node-only type and I was using plain ArrayBuffer and Uint8Array on web

This revision is now accepted and ready to land.Thu, Sep 26, 2:14 AM
marcin edited the test plan for this revision. (Show Details)Fri, Sep 27, 7:10 AM
marcin updated this revision to Diff 44641.Fri, Sep 27, 7:41 AM

Rebase

This revision was landed with ongoing or failed builds.Fri, Sep 27, 7:48 AM
Closed by commit rCOMM0a028741d881: Add AES cryptography to EncryptedNotifUtilsAPI (authored by marcin). · Explain Why
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM0a028741d881: Add AES cryptography to EncryptedNotifUtilsAPI.
Harbormaster completed remote builds in B31908: Diff 44641.Fri, Sep 27, 8:02 AM

Revision Contents
Changeset List

PathSize
keyserver/
src/
push/
30 lines
lib/
types/
8 lines
utils/
__mocks__/
4 lines
native/
push/
37 lines
web/
push-notif/
36 lines

Diff 44561

View Options

keyserver/src/push/encrypted-notif-utils-api.js

Loading...
View Options

lib/types/notif-types.js

Loading...
View Options

lib/utils/__mocks__/config.js

Loading...
View Options

native/push/encrypted-notif-utils-api.js

Loading...
View Options

web/push-notif/encrypted-notif-utils-api.js

Loading...