Paths

Table of Contentst

[lib] send confirmation for ignored DM ops
ClosedPublic
Actions

Authored by kamil on Wed, Oct 9, 7:41 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Oct 15, 12:00 AM

	Unknown Object (File)
	Mon, Oct 14, 12:12 PM

	Unknown Object (File)
	Sun, Oct 13, 9:03 AM

	Unknown Object (File)
	Thu, Oct 10, 10:50 PM

	Unknown Object (File)
	Thu, Oct 10, 7:32 PM

	Unknown Object (File)
	Thu, Oct 10, 7:53 AM

	Unknown Object (File)
	Thu, Oct 10, 7:40 AM

	Unknown Object (File)
	Thu, Oct 10, 7:17 AM

View All 11 Files

Subscribers

ashoat

Details

Reviewers

tomek

Commits

rCOMMeed6217c4364: [lib] send confirmation for ignored DM ops

Summary

ENG-9456.

Avoiding keeping this operation forever when it's invalid.

Depends on D13662

Test Plan

Created DM Op which will be ignored and make sure it is confirmed.

Diff Detail

Repository

rCOMM Comm

Branch

fix-count

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Wed, Oct 9, 7:41 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptWed, Oct 9, 7:41 AM

kamil published this revision for review.Wed, Oct 9, 7:52 AM

Harbormaster completed remote builds in B32145: Diff 45017.Wed, Oct 9, 7:59 AM

Why do we ignore all the promises? What is the downside of awaiting them?

This revision is now accepted and ready to land.Thu, Oct 10, 5:29 AM

use await

Harbormaster completed remote builds in B32223: Diff 45140.Mon, Oct 14, 3:51 AM

Closed by commit rCOMMeed6217c4364: [lib] send confirmation for ignored DM ops (authored by kamil). · Explain WhyMon, Oct 14, 4:07 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMeed6217c4364: [lib] send confirmation for ignored DM ops.

Revision Contents
Changeset List

Path

Size

lib/

shared/

dm-ops/

process-dm-ops.js

6 lines

Diff 45017

View Options

lib/shared/dm-ops/process-dm-ops.js

[lib] send confirmation for ignored DM opsClosedPublicActions