lib/shared/chat-message-item-utils.js
19–27 ↗	(On Diff #45041)	Yes, it's necessary. Without explicitly listing `messageInfos` here, Flow deduces that the `...` can contain `messageInfos`. As a result, Flow isn't able to narrow the type when we do a check like this: if (item.messageInfos) { ... }

Closed by commit rCOMMf64b8996fbd4: [lib][native][web] Extract chatMessageItemKey (authored by ashoat). · Explain WhyOct 13 2024, 6:43 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMf64b8996fbd4: [lib][native][web] Extract chatMessageItemKey.

Revision Contents
Changeset List

Path

Size

lib/

shared/

chat-message-item-utils.js

33 lines

native/

chat/

chat-item-height-measurer.react.js

2 lines

chat-list.react.js

3 lines

message-list.react.js

8 lines

message.react.js

4 lines

pinned-messages-screen.react.js

3 lines

robotext-message.react.js

12 lines

utils.js

19 lines

search/

message-search.react.js

3 lines

web/

chat/

chat-message-list.react.js

16 lines

components/

message-result.react.js

1 line

modals/

chat/

pinned-messages-modal.react.js

3 lines

search/

message-search-modal.react.js

3 lines

Diff 45123

View Options

lib/shared/chat-message-item-utils.js

	// @flow			// @flow

	import type { StoreOperations } from './store-ops-types.js';			import type { StoreOperations } from './store-ops-types.js';

	export type MessageSourceMetadata = {			export type MessageSourceMetadata = {
	+messageID: string,			+messageID: string,
	+senderDeviceID: string,			+senderDeviceID: string,
	};			};

	export type DBOpsEntry =			export type DBOpsEntry =
	\| {			\| {
	+messageSourceMetadata: MessageSourceMetadata,			+messageSourceMetadata: MessageSourceMetadata,
	+ops?: ?StoreOperations,			+ops?: ?StoreOperations,
	}			}
	\| {			\| {
	+ops: StoreOperations,			+ops: StoreOperations,
				+dmOpID?: string,
	};			};

	export type DBOpsStore = {			export type DBOpsStore = {
	+queuedOps: $ReadOnlyArray<DBOpsEntry>,			+queuedOps: $ReadOnlyArray<DBOpsEntry>,
	};			};

View Options

native/chat/chat-item-height-measurer.react.js

	// @flow			// @flow

	import type { StoreOperations } from './store-ops-types.js';			import type { StoreOperations } from './store-ops-types.js';

	export type MessageSourceMetadata = {			export type MessageSourceMetadata = {
	+messageID: string,			+messageID: string,
	+senderDeviceID: string,			+senderDeviceID: string,
	};			};

	export type DBOpsEntry =			export type DBOpsEntry =
	\| {			\| {
	+messageSourceMetadata: MessageSourceMetadata,			+messageSourceMetadata: MessageSourceMetadata,
	+ops?: ?StoreOperations,			+ops?: ?StoreOperations,
	}			}
	\| {			\| {
	+ops: StoreOperations,			+ops: StoreOperations,
				+dmOpID?: string,
	};			};

	export type DBOpsStore = {			export type DBOpsStore = {
	+queuedOps: $ReadOnlyArray<DBOpsEntry>,			+queuedOps: $ReadOnlyArray<DBOpsEntry>,
	};			};

View Options

native/chat/chat-list.react.js

	// @flow			// @flow

	import type { StoreOperations } from './store-ops-types.js';			import type { StoreOperations } from './store-ops-types.js';

	export type MessageSourceMetadata = {			export type MessageSourceMetadata = {
	+messageID: string,			+messageID: string,
	+senderDeviceID: string,			+senderDeviceID: string,
	};			};

	export type DBOpsEntry =			export type DBOpsEntry =
	\| {			\| {
	+messageSourceMetadata: MessageSourceMetadata,			+messageSourceMetadata: MessageSourceMetadata,
	+ops?: ?StoreOperations,			+ops?: ?StoreOperations,
	}			}
	\| {			\| {
	+ops: StoreOperations,			+ops: StoreOperations,
				+dmOpID?: string,
	};			};

	export type DBOpsStore = {			export type DBOpsStore = {
	+queuedOps: $ReadOnlyArray<DBOpsEntry>,			+queuedOps: $ReadOnlyArray<DBOpsEntry>,
	};			};

View Options

native/chat/message-list.react.js

	// @flow			// @flow

	import type { StoreOperations } from './store-ops-types.js';			import type { StoreOperations } from './store-ops-types.js';

	export type MessageSourceMetadata = {			export type MessageSourceMetadata = {
	+messageID: string,			+messageID: string,
	+senderDeviceID: string,			+senderDeviceID: string,
	};			};

	export type DBOpsEntry =			export type DBOpsEntry =
	\| {			\| {
	+messageSourceMetadata: MessageSourceMetadata,			+messageSourceMetadata: MessageSourceMetadata,
	+ops?: ?StoreOperations,			+ops?: ?StoreOperations,
	}			}
	\| {			\| {
	+ops: StoreOperations,			+ops: StoreOperations,
				+dmOpID?: string,
	};			};

	export type DBOpsStore = {			export type DBOpsStore = {
	+queuedOps: $ReadOnlyArray<DBOpsEntry>,			+queuedOps: $ReadOnlyArray<DBOpsEntry>,
	};			};