Paths

Table of Contentst

[keyserver] moving getting neynar config to function
ClosedPublic
Actions

Authored by will on Oct 21 2024, 5:00 AM.

Details

Reviewers

ashoat
varun

Commits

rCOMM8cf7d538a633: [keyserver] moving getting neynar config to function

Summary

In the next diff, verifying the webhook event will require the webhook secret introduced in D13701. Moving grabbing the neynar config to a function to reduce code duplication

Depends on D13841

Test Plan

Later used in a future diff which successfully grabs the webhook secret

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

will created this revision.Oct 21 2024, 5:00 AM

Herald added a subscriber: tomek. · View Herald TranscriptOct 21 2024, 5:00 AM

will added a child revision: D13756: [keyserver] verify webhook event with webhook secret.Oct 21 2024, 5:03 AM

will edited the summary of this revision. (Show Details)Oct 21 2024, 5:04 AM

will added a parent revision: D13754: [keyserver] accept webhook cast created events tagging comm.

Harbormaster completed remote builds in B32311: Diff 45285.Oct 21 2024, 5:17 AM

will requested review of this revision.Oct 21 2024, 5:17 AM

ashoat accepted this revision.Oct 21 2024, 3:54 PM

ashoat added inline comments.

keyserver/src/utils/fc-cache.js
18–23	I wonder if this should be moved to a separate file. It doesn't really have to do with the FC cache

This revision is now accepted and ready to land.Oct 21 2024, 3:54 PM

will added inline comments.Oct 28 2024, 9:06 PM

keyserver/src/utils/fc-cache.js
18–23	I think that makes sense. Decided to move it to a new file `keyserver/src/utils/neynar-utils.js`

move getNeynarConfig to own file

Harbormaster completed remote builds in B32391: Diff 45413.Oct 28 2024, 9:24 PM

will edited parent revisions, added: D13841: [keyserver] add regex #createathread check; removed: D13754: [keyserver] accept webhook cast created events tagging comm.Oct 31 2024, 2:15 PM

will edited the summary of this revision. (Show Details)

Closed by commit rCOMM8cf7d538a633: [keyserver] moving getting neynar config to function. · Explain WhyOct 31 2024, 7:18 PM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMM8cf7d538a633: [keyserver] moving getting neynar config to function.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

utils/

fc-cache.js

15 lines

Diff 45285

View Options

keyserver/src/utils/fc-cache.js

[keyserver] moving getting neynar config to functionClosedPublicActions