[lib] add post cast to neynar client
ClosedPublic
Actions

Authored by will on Oct 23 2024, 11:43 PM.

Details

Reviewers

ashoat
varun

Commits

rCOMMe2c7376fd405: [lib] add post cast to neynar client

Summary

This implements posting a cast using the neynar client.

Followed https://docs.neynar.com/reference/post-cast almost exactly.

Depends on D13783

Test Plan

Unfortunately, something seems to be wrong with the signer uuid configured in our comm neynar account. Debugging, but will ensure a reply cast is properly posted bofore landing

[NODEM]   code: 'NotFound',
[NODEM]   message: 'Signer not found.',
[NODEM]   property: 'signer_uuid'
[NODEM] }

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

will created this revision.Oct 23 2024, 11:43 PM

Herald added a subscriber: tomek. · View Herald TranscriptOct 23 2024, 11:43 PM

will added a child revision: D13785: [keyserver] reply on farcaster with invite link.Oct 23 2024, 11:48 PM

will published this revision for review.Oct 23 2024, 11:52 PM

will edited the test plan for this revision. (Show Details)

Harbormaster completed remote builds in B32362: Diff 45367.Oct 24 2024, 12:01 AM

ashoat accepted this revision.Oct 24 2024, 6:23 AM

ashoat added inline comments.

lib/utils/neynar-client.js
384–386	Nit: not sure this variable adds much?

This revision is now accepted and ready to land.Oct 24 2024, 6:23 AM

fix nit

lib/utils/neynar-client.js
384–386	Fixed nit in latest rebase

Harbormaster completed remote builds in B32459: Diff 45492.Oct 30 2024, 2:51 PM

Closed by commit rCOMMe2c7376fd405: [lib] add post cast to neynar client (authored by will). · Explain WhyOct 31 2024, 12:19 PM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMMe2c7376fd405: [lib] add post cast to neynar client.

Revision Contents
Changeset List

Path

Size

lib/

types/

farcaster-types.js

5 lines

utils/

neynar-client.js

35 lines

Diff 45367

View Options

lib/types/farcaster-types.js

Show First 20 Lines • Show All 59 Lines • ▼ Show 20 Lines	function useFetchEntries(): (
calendarQuery: CalendarQuery,		calendarQuery: CalendarQuery,
) => Promise<FetchEntryInfosResult> {		) => Promise<FetchEntryInfosResult> {
return useKeyserverCall(fetchEntries);		return useKeyserverCall(fetchEntries);
}		}

export type UpdateCalendarQueryInput = {		export type UpdateCalendarQueryInput = {
+calendarQuery: CalendarQuery,		+calendarQuery: CalendarQuery,
+reduxAlreadyUpdated?: boolean,		+reduxAlreadyUpdated?: boolean,
		+keyserverIDs?: $ReadOnlyArray<string>,
};		};

const updateCalendarQueryActionTypes = Object.freeze({		const updateCalendarQueryActionTypes = Object.freeze({
started: 'UPDATE_CALENDAR_QUERY_STARTED',		started: 'UPDATE_CALENDAR_QUERY_STARTED',
success: 'UPDATE_CALENDAR_QUERY_SUCCESS',		success: 'UPDATE_CALENDAR_QUERY_SUCCESS',
failed: 'UPDATE_CALENDAR_QUERY_FAILED',		failed: 'UPDATE_CALENDAR_QUERY_FAILED',
});		});
const updateCalendarQuery =		const updateCalendarQuery =
(		(
callKeyserverEndpoint: CallKeyserverEndpoint,		callKeyserverEndpoint: CallKeyserverEndpoint,
allKeyserverIDs: $ReadOnlyArray<string>,		allKeyserverIDs: $ReadOnlyArray<string>,
): ((		): ((
input: UpdateCalendarQueryInput,		input: UpdateCalendarQueryInput,
) => Promise<CalendarQueryUpdateResult>) =>		) => Promise<CalendarQueryUpdateResult>) =>
async input => {		async input => {
const { calendarQuery, reduxAlreadyUpdated = false } = input;		const { calendarQuery, reduxAlreadyUpdated = false } = input;

		const keyserverIDs = input.keyserverIDs ?? allKeyserverIDs;

const calendarQueries = sortCalendarQueryPerKeyserver(		const calendarQueries = sortCalendarQueryPerKeyserver(
calendarQuery,		calendarQuery,
allKeyserverIDs,		keyserverIDs,
);		);

const requests: { [string]: CalendarQuery } = {};		const requests: { [string]: CalendarQuery } = {};
for (const keyserverID of allKeyserverIDs) {		for (const keyserverID of keyserverIDs) {
requests[keyserverID] = calendarQueries[keyserverID];		requests[keyserverID] = calendarQueries[keyserverID];
}		}

const responses = await callKeyserverEndpoint(		const responses = await callKeyserverEndpoint(
'update_calendar_query',		'update_calendar_query',
requests,		requests,
);		);
let rawEntryInfos: $ReadOnlyArray<RawEntryInfo> = [];		let rawEntryInfos: $ReadOnlyArray<RawEntryInfo> = [];
let deletedEntryIDs: $ReadOnlyArray<string> = [];		let deletedEntryIDs: $ReadOnlyArray<string> = [];
for (const keyserverID in responses) {		for (const keyserverID in responses) {
rawEntryInfos = rawEntryInfos.concat(		rawEntryInfos = rawEntryInfos.concat(
responses[keyserverID].rawEntryInfos,		responses[keyserverID].rawEntryInfos,
);		);
deletedEntryIDs = deletedEntryIDs.concat(		deletedEntryIDs = deletedEntryIDs.concat(
responses[keyserverID].deletedEntryIDs,		responses[keyserverID].deletedEntryIDs,
);		);
}		}
return {		return {
rawEntryInfos,		rawEntryInfos,
deletedEntryIDs,		deletedEntryIDs,
calendarQuery,		calendarQuery,
calendarQueryAlreadyUpdated: reduxAlreadyUpdated,		calendarQueryAlreadyUpdated: reduxAlreadyUpdated,
		keyserverIDs,
};		};
};		};

function useUpdateCalendarQuery(): (		function useUpdateCalendarQuery(): (
input: UpdateCalendarQueryInput,		input: UpdateCalendarQueryInput,
) => Promise<CalendarQueryUpdateResult> {		) => Promise<CalendarQueryUpdateResult> {
return useKeyserverCall(updateCalendarQuery);		return useKeyserverCall(updateCalendarQuery);
}		}
▲ Show 20 Lines • Show All 223 Lines • Show Last 20 Lines