Page MenuHomePhabricator
Differential D13833

[keyserver] Use fetchServerThreadInfos instead of fetchThreadInfos for updateRole
ClosedPublic
Actions

Authored by will on Wed, Oct 30, 12:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 21, 8:14 AM
Unknown Object (File)
Thu, Nov 21, 4:25 AM
Unknown Object (File)
Sat, Nov 16, 2:44 AM
Unknown Object (File)
Fri, Nov 15, 7:36 PM
Unknown Object (File)
Fri, Nov 15, 7:59 AM
Unknown Object (File)
Fri, Nov 15, 2:50 AM
Unknown Object (File)
Fri, Nov 15, 2:47 AM
Unknown Object (File)
Thu, Nov 14, 6:49 PM
View All 27 Files
Subscribers
tomek

Details

Reviewers
ashoat
varun
Commits
rCOMM8af524910694: [keyserver] Use fetchServerThreadInfos instead of fetchThreadInfos for…
Summary

Using fetchThreadInfos in updateRole with the commbot ghost viewer results in the request's thread being filtered out. We instead use fetchServerThreadInfos instead here to avoid filtering based on the viewer

Depends on D13832

Test Plan

No longer received ServerError: invalid_parameters later in stack when attempting to create a farcaster channel community with farcaster bot and updating role with commbot as viewer

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will created this revision.Wed, Oct 30, 12:45 PM
Herald added a subscriber: tomek. · View Herald TranscriptWed, Oct 30, 12:45 PM
will added a child revision: D13834: [keyserver] Run num admin change checks in updateRole only if intended role is not an admin.Wed, Oct 30, 1:00 PM
will added a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.Wed, Oct 30, 1:31 PM
will removed a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.
Harbormaster completed remote builds in B32450: Diff 45483.Wed, Oct 30, 1:36 PM
will requested review of this revision.Wed, Oct 30, 1:36 PM
ashoat accepted this revision.Wed, Oct 30, 2:40 PM
This revision is now accepted and ready to land.Wed, Oct 30, 2:40 PM
will added a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.Wed, Oct 30, 6:10 PM
will removed a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.Thu, Oct 31, 7:17 AM
will added a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.Thu, Oct 31, 9:25 AM
will removed a child revision: D13775: [keyserver] add community creation logic to farcaster webhook responder.Thu, Oct 31, 12:07 PM
Closed by commit rCOMM8af524910694: [keyserver] Use fetchServerThreadInfos instead of fetchThreadInfos for… (authored by will). · Explain WhyThu, Oct 31, 12:19 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM8af524910694: [keyserver] Use fetchServerThreadInfos instead of fetchThreadInfos for….

Revision Contents
Changeset List

PathSize
keyserver/
src/
updaters/
2 lines

Diff 45483

View Options

keyserver/src/updaters/thread-updaters.js

Loading...